Fix displayed name for GNOME Terminal and Black Box #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libmacchina uses /proc/<pid>/comm, which is limited to 15 chars and it's not guaranteed to hold a user friendly name. For example GNOME Terminal is actually /usr/libexec/gnome-terminal-server and its `comm` is `gnome-terminal-`. Add a replacement function that returns user friendly names and that can be expanded with more.
Member
|
While the current method for looking up the terminal emulator is a complete hack - it's probably best to ask the display server or compositor what the current window is, but to my knowledge Wayland still does not offer this - this is a good initiative. |
grtcdr
requested changes
Jun 22, 2024
Comment on lines
442
to
+443
| let terminal = terminal_name(); | ||
| let terminal = terminal_replacements(&terminal); |
Member
There was a problem hiding this comment.
I think this should be a one-liner, the function should also be renamed to convey its function more clearly.
Author
There was a problem hiding this comment.
wdyt about terminal_user_friendy_name() or terminal_display_name()?
What do you mean about it being a one liner? Like the whole PR or the changes to terminal_name()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libmacchina uses /proc//comm, which is limited to 15 chars and it's not guaranteed to hold a user friendly name.
For example GNOME Terminal is actually /usr/libexec/gnome-terminal-server and its
commisgnome-terminal-.Add a replacement function that returns user friendly names and that can be expanded with more.