Skip to content

call_later should always return TimerHandle #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

call_later should always return TimerHandle #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afb0b06
call_later should always return TimerHandle
jensbjorgensen Oct 22, 2025
f2ec97f
fix flake8 issues
jensbjorgensen Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,6 +938,12 @@ def test_loop_call_later_handle_when_after_fired(self):
self.loop.run_until_complete(fut)
self.assertEqual(handle.when(), when)

def test_loop_call_later_0_returns_timer_handle(self):
cb = lambda: False # NoQA
handle = self.loop.call_later(0, cb)
handle.when()
handle.cancel()


class TestBaseAIO(_TestBase, AIOTestCase):
pass
Expand Down
5 changes: 1 addition & 4 deletions uvloop/loop.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,10 +1326,7 @@ cdef class Loop:
when = <uint64_t>round(delay * 1000)
if not args:
args = None
if when == 0:
return self._call_soon(callback, args, context)
else:
return self._call_later(when, callback, args, context)
return self._call_later(when, callback, args, context)

def call_at(self, when, callback, *args, context=None):
"""Like call_later(), but uses an absolute time.
Expand Down
Loading