Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Plots created by
plotlistdon't cycle properly.Computation of the
cycle_indexviaplot_cycle_indexcan now also work withPlotListobjects.We also recurse
PlotListobjects inscene.plots.In
diff_plotlist!we have to keep in mind that the currentplotlistis not yet inscene.plots, so compute an offset.plot_cycle_indexdid not look quite right with thespecs, spec::PlotSpec, plot::Plotsignature, but I don't know how to test it.Seems to fix #4843 #4353 #4322
Type of change
Delete options that do not apply:
Checklist