fix: FTS contentless table and category_primary mismatch #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2025 09:19
Fixes two issues that prevented memory retrieval from working: 1. FTS contentless table issue (search_service.py) - FTS table is created with content='' (contentless) - Directly reading FTS columns returns NULL - Fixed by using rowid JOIN to source tables 2. category_primary mismatch (memory.py) - get_essential_conversations queried 'essential_%' - But actual values are 'conscious_context', 'conscious-info', etc. - Fixed by matching both 'essential%' and 'conscious%' patterns Tested: retrieve_context and get_essential_conversations now return correct results
WHAT: 将 FTS 表从 contentless 模式改为存储完整数据 WHY: contentless FTS 表的 rowid 与源表不对应，导致 JOIN 时匹配不到正确记录，搜索返回空结果 HOW: 1. FTS 表直接存储 memory_id、memory_type、user_id、searchable_content 等字段 2. 搜索时直接从 FTS 表读取，不再依赖 rowid 3. 只在需要 processed_data、importance_score 等额外字段时才通过 memory_id JOIN 源表
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues that prevented memory retrieval from working:
FTS contentless table issue (search_service.py)
category_primary mismatch (memory.py)
Tested: retrieve_context and get_essential_conversations now return correct results