-
Notifications
You must be signed in to change notification settings - Fork 5.4k
release(runway): cherry-pick feat: import srp hide show all cp-12.22.0 #33955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HowardBraham
merged 1 commit into
Version-v12.22.0
from
runway-cherry-pick-12.22.0-1751019613
Jun 27, 2025
Merged
release(runway): cherry-pick feat: import srp hide show all cp-12.22.0 #33955
HowardBraham
merged 1 commit into
Version-v12.22.0
from
runway-cherry-pick-12.22.0-1751019613
Jun 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#33949) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Hide Show/Hide All SRP. Users can view/edit SRP one at a time by clicking on the text field  https://github.com/user-attachments/assets/de8d9ce1-f112-4c00-9946-d7a9965f393d <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33946?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [5460c0f]
UI Startup Metrics (1180 ± 54 ms)
Benchmark value 2589 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 293 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1689 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 253 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 44 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1994 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive Sum of mean exceeds: 11ms | Sum of p95 exceeds: 687ms Sum of all benchmark exceeds: 698ms |
HowardBraham
approved these changes
Jun 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide Show/Hide All SRP. Users can view/edit SRP one at a time by
clicking on the text field
Screen.Recording.2025-06-27.at.3.20.25.PM.mov
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. 46e2b95