Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Jun 27, 2025

Description

Hide Show/Hide All SRP. Users can view/edit SRP one at a time by
clicking on the text field

Screenshot 2025-06-27 at 3 18 25 PM

Screen.Recording.2025-06-27.at.3.20.25.PM.mov

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. 46e2b95

#33949)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Hide Show/Hide All SRP. Users can view/edit SRP one at a time by
clicking on the text field

![Screenshot 2025-06-27 at 3 18
25 PM](https://github.com/user-attachments/assets/23268e51-d864-4ed7-85d9-9f864fffe762)


https://github.com/user-attachments/assets/de8d9ce1-f112-4c00-9946-d7a9965f393d

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/33946?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Jun 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [5460c0f]
UI Startup Metrics (1180 ± 54 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1180108813935412111271
load101491011465110391101
domContentLoaded100890711265010331096
domInteractive18135171738
firstPaint72879113739510351094
backgroundConnect74344710
firstReactRender21174742227
getState1363981831
initialActions001000
loadScripts80270792050827895
setupStore95314819
WebpackHomeuiStartup21521710264020922512589
load16441223206619217451972
domContentLoaded16381219206119217421963
domInteractive171174131352
firstPaint1676439459194301
backgroundConnect2410412402235
firstReactRender22490425118381403
getState1052441220
initialActions317134
loadScripts16351216205219017401962
setupStore2873146316293
FirefoxBrowserifyHomeuiStartup13951208175011414351689
load1223107514588312751378
domContentLoaded1222107514578312751378
domInteractive1163851467121253
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2214129122229
firstReactRender24213832532
getState1259014944
initialActions001001
loadScripts1203106214438312521354
setupStore94509735
WebpackHomeuiStartup15331356209717315831994
load13241172180014713921651
domContentLoaded13241172179914713921650
domInteractive89303855985271
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22164562339
firstReactRender39305444245
getState1254081032
initialActions102111
loadScripts13051156177314613741622
setupStore95336826
Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore
Benchmark value 2589 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 403 exceeds gate value 370 for chrome webpack home p95 firstReactRender
Benchmark value 293 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 1689 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 253 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 44 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 40 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1994 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive
Sum of mean exceeds: 11ms | Sum of p95 exceeds: 687ms
Sum of all benchmark exceeds: 698ms

@HowardBraham HowardBraham merged commit eb00a1e into Version-v12.22.0 Jun 27, 2025
142 checks passed
@HowardBraham HowardBraham deleted the runway-cherry-pick-12.22.0-1751019613 branch June 27, 2025 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants