-
Notifications
You must be signed in to change notification settings - Fork 5.4k
chore: add Keycard Shell to the list of supported QR hardware wallets #36911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
de3419a to
4f661a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing Keycard Shell in QrHardwareDeviceNames enum
The QrHardwareDeviceNames enum is missing a Keycard Shell entry, while the new code in select-hardware.js references it. All other QR wallet implementations use an entry from this enum for tracking, but Keycard Shell doesn't have a corresponding entry, creating an inconsistency in how device names are managed across QR hardware wallets.
shared/constants/hardware-wallets.ts#L59-L67
metamask-extension/shared/constants/hardware-wallets.ts
Lines 59 to 67 in 6b7ecb0
| export enum QrHardwareDeviceNames { | |
| Keystone = 'Keystone', | |
| AirGap = 'AirGap Vault', | |
| CoolWallet = 'CoolWallet', | |
| DCent = 'DCent', | |
| Ngrave = 'Ngrave', | |
| ImToken = 'imToken', | |
| } |
Description
This PR adds Keycard Shell to the list of supported QR hardware wallets. We have performed extensive tests between Keycard Shell and MetaMask and can confirm full compatibility.
Changelog
CHANGELOG entry: Added Keycard Shell to the list of QR-based hardware wallets
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds Keycard Shell as a supported QR hardware wallet with UI option, constants/links, i18n strings, and issue template entry.
ui/pages/create-account/connect-hardware/select-hardware.js, addsKeycard ShellQR wallet option with Buy/Tutorial buttons, link opens, and marketing event tracking (QrHardwareDeviceNames.KShell).shared/constants/hardware-wallets.ts, addsKShelltoQrHardwareDeviceNames,HardwareAffiliateLinks, andHardwareAffiliateTutorialLinkswith URLs.keycardShellmessage to multiple locale files (e.g.,app/_locales/en/messages.json,.../de,.../es, etc.)..github/ISSUE_TEMPLATE/bug-report.ymlto includeKeycard Shellin hardware wallet options.Written by Cursor Bugbot for commit 2a80dad. This will update automatically on new commits. Configure here.