feat: rwds-276 show rewards balance #37361
Open
+1,968
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0d38064]
UI Startup Metrics (1272 ± 83 ms)
|
sophieqgu
force-pushed
the
feat/rwds-276
branch
from
0d38064 to
b1f1847
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [b1f1847]
UI Startup Metrics (1280 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sophieqgu
force-pushed
the
feat/rwds-276
branch
from
b1f1847 to
e43a1b9
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e43a1b9]
UI Startup Metrics (1284 ± 85 ms)
|
sophieqgu
force-pushed
the
feat/rwds-276
branch
from
e43a1b9 to
08dc827
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [08dc827]
UI Startup Metrics (1240 ± 77 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
I have read the CLA Document and I hereby sign the CLA |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [979f7ea]
UI Startup Metrics (1258 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sophieqgu
force-pushed
the
feat/rwds-276
branch
from
9e54f7f to
dbdf7b3
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [dbdf7b3]
UI Startup Metrics (1255 ± 88 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [aa517e9]
UI Startup Metrics (1269 ± 104 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sophieqgu
force-pushed
the
feat/rwds-276
branch
from
b0e0de6 to
7011f97
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [7011f97]
UI Startup Metrics (1222 ± 102 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [1e17376]
UI Startup Metrics (1295 ± 88 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sophieqgu
force-pushed
the
feat/rwds-276
branch
from
3a30a8d to
ebfd5fe
Compare
| expect(mockSubmitRequestToBackground).toHaveBeenCalledWith( | ||
| 'getRewardsSeasonStatus', | ||
| ['test-subscription-id', undefined], | ||
| ); |
There was a problem hiding this comment.
Bug: Mocking Error Causes Undefined Season ID
The useSeasonStatus tests incorrectly mock submitRequestToBackground to always return a SeasonStatusState. The getRewardsSeasonMetadata call expects a SeasonDtoState with a top-level id. This type mismatch causes the season ID to be undefined when passed to getRewardsSeasonStatus, and the tests then incorrectly assert this undefined value.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [ebfd5fe]
UI Startup Metrics (1266 ± 69 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI components/hook needed to show rewards balance
Changelog
CHANGELOG entry: show rewards balance
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/RWDS-276
Screenshots/Recordings
After
TODO
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds rewards points balance badge to Wallet Overview backed by new rewards context/hooks, shared types, background calls, i18n, and tests.
RewardsPointsBalancecomponent showing localized points or opt-in badge with new icon; render inwallet-overview/coin-overview.tsxwhen rewards enabled.RewardsProvideranduseRewardsContextto surfacecandidateSubscriptionIdand season status.useRewardsEnabled,useCandidateSubscriptionId,useSeasonStatusfor feature gating and data fetching.metamask-controller:getCandidateSubscriptionId,getRewardsSeasonMetadata,getRewardsSeasonStatus.shared/types/rewardsand update controller/types/tests to import from shared.metamask-rewards-points.svgand new messages:rewardsOptIn,rewardsPointsBalance,rewardsPointsIconinenanden_GB.RewardsPointsBalanceand hooks (useRewardsEnabled,useCandidateSubscriptionId,useSeasonStatus).Written by Cursor Bugbot for commit ebfd5fe. This will update automatically on new commits. Configure here.