fix: social login invalid access token #37387
Open
+452
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix/invalid-access-token
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +0 -6)
🧩 @MetaMask/extension-devs (5 files, +84 -15)
📜 @MetaMask/policy-reviewers (5 files, +84 -15)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🧪 @MetaMask/qa (1 files, +14 -0)
🔗 @MetaMask/supply-chain (5 files, +84 -15)
🔐 @MetaMask/web3auth (2 files, +55 -14)
|
lwin-kyaw
added
seedless-onboarding
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [a5119af]
|
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [30201d1]
UI Startup Metrics (1262 ± 89 ms)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [7a93b4a]
UI Startup Metrics (1255 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
No policy changes |
Builds ready [61c39bc]
UI Startup Metrics (1250 ± 83 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [2d07c71]
UI Startup Metrics (1334 ± 119 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Builds ready [856a42c]
UI Startup Metrics (1282 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
lwin-kyaw
force-pushed
the
feat/reset-wallet
branch
from
fc9143f to
d7b8e72
Compare
Builds ready [b73be1f]
UI Startup Metrics (1270 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
lwin-kyaw
force-pushed
the
feat/reset-wallet
branch
from
d7b8e72 to
3f83de9
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Builds ready [4fa1f04]
UI Startup Metrics (1224 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Builds ready [2b5d2c0]
UI Startup Metrics (1271 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Builds ready [3c86839]
UI Startup Metrics (1270 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Builds ready [26a6e80]
UI Startup Metrics (1307 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Builds ready [d9e19bb]
UI Startup Metrics (1261 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
Invalid Access Tokenerror during the rehydrate/create with social login and updates@metamask/seedless-onboarding-controllertov6.Changelog
CHANGELOG entry: fixed
Invalid Access Tokenerror during the rehydrate/create with social loginCHANGELOG entry: updated
@metamask/seedless-onboarding-controllertov6.Related issues
Fixes: #37337
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refactors social-login rehydration and unlock flows (auth check, error-driven reset with new ConnectionsRemoved modal), exposes an auth-check method, updates tests and LavaMoat policies, and upgrades seedless onboarding deps to v6.
getIsSeedlessOnboardingUserAuthenticatedviametamask-controllerand add thunkgetIsSeedlessOnboardingUserAuthenticated.syncPasswordAndUnlockWallet(password)to stop returning a boolean; streamline password sync flow and error handling.ConnectionsRemovedModalto be controlled by caller (onConfirmprop); removeshowConnectionsRemovedModalstate, selector, and actions; stop rendering it inHome.UnlockPage: redirect toONBOARDING_WELCOME_ROUTEif user not authenticated during rehydration; showConnectionsRemovedModalonMaxKeyChainLengthExceededand reset wallet from there; minor login/reset flow tweaks.CreatePassword: validate authenticated social session and redirect to welcome if not authenticated.TOPRFGetPubKeyand password-outdated checks.@metamask/toprf-secure-backupdeps and new@metamask/auth-network-utilspaths.@metamask/seedless-onboarding-controllerto6.0.0-previewand update related deps (@metamask/toprf-secure-backup^0.10,@metamask/auth-network-utils^0.4,@toruslabs/eccrypto^6.2); refreshyarn.lock.Written by Cursor Bugbot for commit d9e19bb. This will update automatically on new commits. Configure here.