chore: bump @metamask/{keyring,seedless-onboarding}-controller
#37454
+35
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
mikesposito
changed the title
@metamask/{keyring,seedless-onboarding}-controller@metamask/{keyring,seedless-onboarding}-controller
Member
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (6 files, +5 -120)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Collaborator
Builds ready [5d92049]
UI Startup Metrics (1277 ± 78 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Member
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [e776872]
UI Startup Metrics (1213 ± 85 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mikesposito
force-pushed
the
mikesposito/update-keyring-controller
branch
from
f70e5ae to
825bbeb
Compare
Member
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [0a057de]
UI Startup Metrics (1218 ± 80 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [acb5bf2]
UI Startup Metrics (1200 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Member
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [9126053]
UI Startup Metrics (1257 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [14cfe12]
UI Startup Metrics (1223 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
Comment on lines
-49
to
-56
| let payload: EncryptionResult; | ||
| if (typeof encryptedData === 'string') { | ||
| payload = JSON.parse(encryptedData); | ||
| } else { | ||
| payload = encryptedData; | ||
| } | ||
|
|
||
| return encryptor.decryptWithKey(key as EncryptionKey, payload); |
Member
There was a problem hiding this comment.
Is this compatible with the encryptor passed now?
Member
Author
There was a problem hiding this comment.
There has been this broken type in KeyringController for a while now, but it was aligned with the real type coming from browser-passworder here: https://github.com/MetaMask/core/pull/7127/files#diff-cacd62f731d7f6947fe841f6ba3441c7a16f764b699801b0c212e0e6c15879bfR423 - encryptedData should never be a string when being decrypted with decryptWithKey
Member
There was a problem hiding this comment.
Just making sure that the SeedlessOnboardingController doesn't expect to be able to pass a string? But I guess not since the types are valid
Member
Author
There was a problem hiding this comment.
Correct, SeedlessOnboardingController always parses the vault before passing it to decryptWithKey: https://github.com/MetaMask/core/blob/8f42d26998ec95ccbcc3dba16d6aff0490cec052/packages/seedless-onboarding-controller/src/SeedlessOnboardingController.ts#L1403-L1403
FrederikBolding
approved these changes
Dec 3, 2025
Collaborator
Builds ready [3733c29]
UI Startup Metrics (1270 ± 116 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚀 Bundle size reduced!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on MetaMask/core#7128
Description
Bumping
keyring-controllerandseedless-onboarding-controllerto pick up the latest changes.@metamask/browser-passworderis also being bumped to^6.0.0, and the encryptor factory has been adjusted to includekeyFromPassword,generateSaltandexportKeyas they are required byKeyringController.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Upgrades keyring, seedless onboarding, and passworder deps and updates controller init, types, tests, and policies to the new encryptor API (removes
cacheEncryptionKey).@metamask/keyring-controllerto^25.0.0,@metamask/seedless-onboarding-controllerto^7.0.0, and@metamask/browser-passworderto^6.0.0.keyring-controller-init: removecacheEncryptionKeywhen constructingKeyringController.seedless-onboarding-controller-init: useSeedlessOnboardingController<CryptoKey | EncryptionKey>and passencryptordirectly (drop custom wrapper).encryptortype from optionalExportableKeyEncryptorto requiredEncryptorincontroller-init/types.encryptWithKey,isVaultUpdated,exportKey,generateSalt,keyFromPassword).importKeyreturning parsed key and newexportKey.cacheEncryptionKeyfrom test expectation.browser-passworderchanges (remove nested package allowances, adjust to@metamask/utils).Written by Cursor Bugbot for commit 3733c29. This will update automatically on new commits. Configure here.