-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: wrong stx chain id #37461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong stx chain id #37461
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨💸 @MetaMask/transactions (1 files, +1 -0)
|
Builds ready [d197348]
UI Startup Metrics (1264 ± 129 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d980314]
UI Startup Metrics (1258 ± 83 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [cfdb0a9]
UI Startup Metrics (1215 ± 94 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [14d874c]
UI Startup Metrics (1251 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Fixes #37194
Changelog
CHANGELOG entry: Fixed the smart transaction link
Related issues
Fixes: #37194
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Pass
chainIdthrough smart transaction approval state and read it in the status page to build the correct Portfolio link; update test mocks accordingly.chainIdinrequestState.smartTransactionwhen adding the approval request inapp/scripts/lib/smart-transaction/smart-transactions.ts.ui/pages/.../smart-transaction-status-page.tsx: Stop using network selector; readchainIdfromsmartTransaction.chainIdto construct the Portfolio status URL.test/jest/mock-store.js: AddchainIdto mocked smart transaction entries.Written by Cursor Bugbot for commit 14d874c. This will update automatically on new commits. Configure here.