Skip to content

Conversation

@klejeune
Copy link
Contributor

@klejeune klejeune commented Nov 3, 2025

Description

Fixes #37194

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Fixed the smart transaction link

Related issues

Fixes: #37194

Manual testing steps

  1. Make sure smart transactions are enabled
  2. Perform a Send on Ethereum mainnet, BSC or Base
  3. Make sure the "View transaction" link is displayed immediately after confirming the transaction (it should be instant)
  4. Click on the link and make sure the transaction details are displayed

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Pass chainId through smart transaction approval state and read it in the status page to build the correct Portfolio link; update test mocks accordingly.

  • Smart Transactions Flow:
    • Include chainId in requestState.smartTransaction when adding the approval request in app/scripts/lib/smart-transaction/smart-transactions.ts.
  • UI:
    • ui/pages/.../smart-transaction-status-page.tsx: Stop using network selector; read chainId from smartTransaction.chainId to construct the Portfolio status URL.
  • Tests/Mocks:
    • test/jest/mock-store.js: Add chainId to mocked smart transaction entries.

Written by Cursor Bugbot for commit 14d874c. This will update automatically on new commits. Configure here.

@klejeune klejeune requested a review from a team as a code owner November 3, 2025 13:20
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@klejeune klejeune changed the title fix: wrong stx chain id #37194 fix: wrong stx chain id Nov 3, 2025
@metamaskbot metamaskbot added the team-transactions Transactions team label Nov 3, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

💸 @MetaMask/transactions (1 files, +1 -0)
  • 📁 app/
    • 📁 scripts/
      • 📁 lib/
        • 📁 smart-transaction/
          • 📄 smart-transactions.ts +1 -0

@metamaskbot
Copy link
Collaborator

Builds ready [d197348]
UI Startup Metrics (1264 ± 129 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12641119219512913001437
load1083953189911311201235
domContentLoaded1077947187711211141226
domInteractive211478141864
firstPaint66471192244810861180
backgroundConnect2302172698234243
firstReactRender29176593546
getState22799122546
initialActions717010819
loadScripts8527271624109890992
setupStore1163141217
numNetworkReqs1367520672
BrowserifyPower User HomeuiStartup20991786354945821653549
load1093922174423713191744
domContentLoaded1084914173723413101737
domInteractive271664154464
firstPaint76117614484139751448
backgroundConnect24522132524255325
firstReactRender27243022830
getState18915624925211249
initialActions52153615
loadScripts855701146022310781460
setupStore1091211112
numNetworkReqs1539031083274310
WebpackStandard HomeuiStartup9207801317999361154
load672607107382680863
domContentLoaded662601105379673846
domInteractive17125791544
firstPaint205591056207211634
backgroundConnect3012111173274
firstReactRender31186093742
getState1473341621
initialActions41354411
loadScripts659599104277670835
setupStore1262841519
numNetworkReqs1367619870
WebpackPower User HomeuiStartup13681170185121415991851
load71161210581468351058
domContentLoaded675601894104730894
domInteractive221358153458
firstPaint30373901306619901
backgroundConnect761225984155259
firstReactRender27254042740
getState14610816018157160
initialActions615313553
loadScripts671599884100720884
setupStore1062451024
numNetworkReqs1659029371228293
FirefoxBrowserifyStandard HomeuiStartup15271254199613716021836
load1290107516229413631458
domContentLoaded1290107516229413621457
domInteractive1235139050130217
firstPaint------
backgroundConnect52263704452133
firstReactRender26224942735
getState85475715
initialActions42193412
loadScripts1257105714488413111421
setupStore168201261240
numNetworkReqs1367017763
BrowserifyPower User HomeuiStartup23662102321933525243219
load13751134191926116261919
domContentLoaded13751134191926116261919
domInteractive18687572149344572
firstPaint------
backgroundConnect963134794167347
firstReactRender36284874448
getState1259716621138166
initialActions62225922
loadScripts13391115182524315711825
setupStore23773173673
numNetworkReqs1377032476220324
WebpackStandard HomeuiStartup16301410245321516262302
load13821218183212314071653
domContentLoaded13821218183212314071653
domInteractive1032949257108165
firstPaint------
backgroundConnect53243104551127
firstReactRender332377153274
getState1049912924
initialActions41234312
loadScripts13501200174510713771616
setupStore205258401254
numNetworkReqs1367018767
WebpackPower User HomeuiStartup24572123314032726793140
load14261191178919016271789
domContentLoaded14261190178819016271788
domInteractive16569434133330434
firstPaint------
backgroundConnect89313548098354
firstReactRender413167104767
getState1358120934152209
initialActions131139339139
loadScripts13951171174418415971744
setupStore28781214681
numNetworkReqs1386733892204338
📊 Page Load Benchmark Results

Current Commit: d197348 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.02s (±42ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 710ms (±38ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.02s 42ms 1.00s 1.32s 1.03s 1.32s
domContentLoaded 710ms 38ms 692ms 979ms 726ms 979ms
firstPaint 74ms 11ms 56ms 160ms 84ms 160ms
firstContentfulPaint 74ms 11ms 56ms 160ms 84ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 86 Bytes (0%)
  • ui: -120 Bytes (0%)
  • common: 10 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [d980314]
UI Startup Metrics (1258 ± 83 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1258110514288313041414
load107694812427411221200
domContentLoaded107094312347311171193
domInteractive201469111754
firstPaint65888123842510601200
backgroundConnect2282162497232242
firstReactRender3218134153551
getState2187492434
initialActions70587822
loadScripts849729101572898970
setupStore1162741220
numNetworkReqs1367619670
BrowserifyPower User HomeuiStartup20891794292831921332928
load1114981147417713371474
domContentLoaded1102970143816913271438
domInteractive311781225081
firstPaint839178145540410301455
backgroundConnect25223329117264291
firstReactRender29253733137
getState1828923930200239
initialActions62174617
loadScripts866744118716410741187
setupStore14102961529
numNetworkReqs15310231774199317
WebpackStandard HomeuiStartup87174112201028721146
load64959096385646899
domContentLoaded64158294582639885
domInteractive16114571539
firstPaint19960949205184617
backgroundConnect261187152966
firstReactRender29176293445
getState1262541417
initialActions31143410
loadScripts63858093480637874
setupStore1052031216
numNetworkReqs1367519870
WebpackPower User HomeuiStartup13531163187128417731871
load678594922118832922
domContentLoaded661583867105806867
domInteractive221271173871
firstPaint29487917241588917
backgroundConnect641120677190206
firstReactRender25233022630
getState14810417318160173
initialActions206226
loadScripts657581857101796857
setupStore1162771327
numNetworkReqs1558228672217286
FirefoxBrowserifyStandard HomeuiStartup15191305196513215811770
load1283112114799013421444
domContentLoaded1283112114799013421444
domInteractive1173529743130221
firstPaint------
backgroundConnect50251852855123
firstReactRender26215052638
getState849510817
initialActions42213413
loadScripts1253110214488513211403
setupStore1374171234
numNetworkReqs1367417765
BrowserifyPower User HomeuiStartup26052158384450329303844
load13841175181619815741816
domContentLoaded13841174181419715741814
domInteractive22685622185429622
firstPaint------
backgroundConnect15826521150270521
firstReactRender39305284952
getState1319321128141211
initialActions2112526011252
loadScripts13411157177219015351772
setupStore3861844458184
numNetworkReqs1406932680218326
WebpackStandard HomeuiStartup16571447221115116632018
load14031251181310614271656
domContentLoaded14031251181210614271656
domInteractive1033742143110159
firstPaint------
backgroundConnect51271432554113
firstReactRender332477133276
getState949811818
initialActions52487422
loadScripts1372121417799813931555
setupStore167108171349
numNetworkReqs1366717764
WebpackPower User HomeuiStartup26262219359942429703599
load15371315204522717852045
domContentLoaded15361314204522717852045
domInteractive17877578148348578
firstPaint------
backgroundConnect11239478107135478
firstReactRender41335784857
getState1459028251169282
initialActions813591135
loadScripts14891284188620817291886
setupStore4882586885258
numNetworkReqs1366732891220328
📊 Page Load Benchmark Results

Current Commit: d980314 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 715ms (±36ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 39ms 1.00s 1.31s 1.05s 1.31s
domContentLoaded 715ms 36ms 693ms 978ms 738ms 978ms
firstPaint 76ms 13ms 60ms 192ms 84ms 192ms
firstContentfulPaint 76ms 13ms 60ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 86 Bytes (0%)
  • ui: -120 Bytes (0%)
  • common: 10 Bytes (0%)

@klejeune klejeune enabled auto-merge November 4, 2025 08:45
@metamaskbot
Copy link
Collaborator

Builds ready [cfdb0a9]
UI Startup Metrics (1215 ± 94 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1215105416499412581401
load104791913778410851210
domContentLoaded104191313598210791203
domInteractive211383131855
firstPaint59674121541710381150
backgroundConnect2302162619233256
firstReactRender25184962840
getState2065692340
initialActions51284616
loadScripts817695111781857974
setupStore1073541117
numNetworkReqs1367620672
BrowserifyPower User HomeuiStartup20451788265030023982650
load1043895141918912931419
domContentLoaded1035891140418912851404
domInteractive251655144555
firstPaint665167144146910121441
backgroundConnect24422529019264290
firstReactRender29254863148
getState1787724135203241
initialActions1731834310183
loadScripts803668115517910041155
setupStore16947101547
numNetworkReqs199104378107319378
WebpackStandard HomeuiStartup8867431268869081113
load63257392064629801
domContentLoaded62456689961621788
domInteractive181398121550
firstPaint21262904208192739
backgroundConnect291391153062
firstReactRender3319189173841
getState1262131417
initialActions51264514
loadScripts62056488759618777
setupStore1476171525
numNetworkReqs1367218868
WebpackPower User HomeuiStartup14001185201229818042012
load666589956114754956
domContentLoaded648577914106713914
domInteractive29131012660101
firstPaint25680734168311734
backgroundConnect661120274180202
firstReactRender27253422734
getState15111017018163170
initialActions41113611
loadScripts643575903102702903
setupStore1163581535
numNetworkReqs2069732579279325
FirefoxBrowserifyStandard HomeuiStartup14951337199212715651771
load1266112115749213281432
domContentLoaded1265112115749213281431
domInteractive1173632446128230
firstPaint------
backgroundConnect4126121154866
firstReactRender26225352732
getState74424715
initialActions42304413
loadScripts1240110015499012981406
setupStore177246271339
numNetworkReqs1266615760
BrowserifyPower User HomeuiStartup25292115352942626673529
load13951149184921116451849
domContentLoaded13951149184821116451848
domInteractive22389769208290769
firstPaint------
backgroundConnect883025774174257
firstReactRender433075125475
getState1345219131163191
initialActions12195231095
loadScripts13671130182520715981825
setupStore2861583829158
numNetworkReqs1376432590227325
WebpackStandard HomeuiStartup15741405225813815951881
load1337116116909113781533
domContentLoaded1337116116909113771532
domInteractive972919928112150
firstPaint------
backgroundConnect48212153052106
firstReactRender292277102946
getState10416018715
initialActions8118726327
loadScripts1308114515688213481466
setupStore15765121349
numNetworkReqs1367117764
WebpackPower User HomeuiStartup26082197311528628343115
load15771277183718117331837
domContentLoaded15771277183718117321837
domInteractive18439509161435509
firstPaint------
backgroundConnect892725857122258
firstReactRender41326384563
getState1499433253167332
initialActions1811113118111
loadScripts15411260180317317001803
setupStore24675193275
numNetworkReqs1626427775224277
📊 Page Load Benchmark Results

Current Commit: cfdb0a9 | Date: 11/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 992ms (±40ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 688ms (±38ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 992ms 40ms 959ms 1.27s 1.04s 1.27s
domContentLoaded 688ms 38ms 660ms 959ms 729ms 959ms
firstPaint 77ms 10ms 64ms 160ms 84ms 160ms
firstContentfulPaint 77ms 10ms 64ms 160ms 84ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 86 Bytes (0%)
  • ui: -120 Bytes (0%)
  • common: 10 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [14d874c]
UI Startup Metrics (1251 ± 107 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12511086157910713051458
load107292013459411301246
domContentLoaded106691613279311251242
domInteractive221475142061
firstPaint58986134943810491218
backgroundConnect23521930413239260
firstReactRender27185272746
getState2195382537
initialActions61547715
loadScripts8387011099908921016
setupStore1172431218
numNetworkReqs1367519671
BrowserifyPower User HomeuiStartup20291764308836223893088
load1047893173623012611736
domContentLoaded1039886172923012551729
domInteractive261470184870
firstPaint57115713673989081367
backgroundConnect23722227814246278
firstReactRender27243932739
getState18415522120209221
initialActions52122612
loadScripts813668145822010331458
setupStore1593282632
numNetworkReqs212102345101313345
WebpackStandard HomeuiStartup820703117282830968
load60054894673595752
domContentLoaded59254393270589736
domInteractive16114381439
firstPaint19857935195185707
backgroundConnect241271132556
firstReactRender29176693336
getState1152431216
initialActions3012248
loadScripts58954092068587726
setupStore1153251320
numNetworkReqs1367419870
WebpackPower User HomeuiStartup12971123180320114341803
load64656910131267261013
domContentLoaded629556963116694963
domInteractive241377183977
firstPaint31278771220563771
backgroundConnect47171423794142
firstReactRender26243222632
getState1385116328153163
initialActions51226422
loadScripts624554952113683952
setupStore1453192531
numNetworkReqs1849729872259298
FirefoxBrowserifyStandard HomeuiStartup14961303184310815601689
load1266111214047813311399
domContentLoaded1266111214047813311399
domInteractive1183431548136223
firstPaint------
backgroundConnect4628141215094
firstReactRender27227672740
getState84809718
initialActions4114248
loadScripts1239109213767512991358
setupStore14578111438
numNetworkReqs1266816761
BrowserifyPower User HomeuiStartup24952184306526226553065
load13731172179418315211794
domContentLoaded13731172179418315201794
domInteractive21092617173344617
firstPaint------
backgroundConnect13539412104156412
firstReactRender40296694666
getState1377429058134290
initialActions10150131150
loadScripts13251094170018314651700
setupStore321082245682
numNetworkReqs1786731582246315
WebpackStandard HomeuiStartup16171404198511916601888
load1380120516528814411531
domContentLoaded1380120516518814401530
domInteractive1023133040114187
firstPaint------
backgroundConnect5225125226096
firstReactRender28226862838
getState9413415715
initialActions51376315
loadScripts1347118915678314021493
setupStore15799161461
numNetworkReqs1366916764
WebpackPower User HomeuiStartup26732340306025029463060
load16041376185315717711853
domContentLoaded16041376185215717711852
domInteractive16968472123177472
firstPaint------
backgroundConnect924224757104247
firstReactRender473283135383
getState1558122244197222
initialActions711641016
loadScripts15691343180715517391807
setupStore3651062742106
numNetworkReqs1765734284215342
📊 Page Load Benchmark Results

Current Commit: 14d874c | Date: 11/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±36ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 40ms 1.02s 1.33s 1.09s 1.33s
domContentLoaded 734ms 36ms 706ms 995ms 754ms 995ms
firstPaint 79ms 11ms 60ms 176ms 92ms 176ms
firstContentfulPaint 79ms 11ms 60ms 176ms 92ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 86 Bytes (0%)
  • ui: -120 Bytes (0%)
  • common: 10 Bytes (0%)

@klejeune klejeune added this pull request to the merge queue Nov 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2025
@klejeune klejeune added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit e39125e Nov 4, 2025
173 checks passed
@klejeune klejeune deleted the fix/stx-wrong-chain-id branch November 4, 2025 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
@metamaskbot metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.9.0 Issue or pull request that will be included in release 13.9.0 size-XS team-transactions Transactions team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: STX link does not work

5 participants