fix: cp-13.8.0 Fix unknown token issue when nonEVM selected in network manager #37491

OGPoyraz · 2025-11-04T09:26:33Z

Description

This PR aims to fix a bug where token shows as unknown when network manager is selected nonEVM network.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #37428

Manual testing steps

Select nonEVM network (Solana / BTC)
Go to send flow
Pick an ERC20 token (especially not on mainnet)
Proceed send
You should be able to see token name and image in confirmation

Screenshots/Recordings

Before

After

fix.recording.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refactors token resolution in confirmations to use chain-scoped selectors with fallbacks and updates tests for presence/absence cases.

Confirmations UI:
- Hook useTokenDetails:
  - Switches to chain-scoped selectors selectERC20TokensByChain and getAllTokens to resolve token details.
  - Derives erc20Token from erc20TokensByChain[chainId].data[to]; falls back to allTokens[chainId][from] lookup; returns t('unknown') when absent.
  - Removes reliance on getWatchedToken/getTokenList.
- Tests useTokenDetails.test.ts:
  - Updated mocks to new chain-scoped token map shape.
  - Adds/updates cases for token present and for missing token/chain/address returning { tokenImage: undefined, tokenSymbol: 'Unknown' }.

^{Written by Cursor Bugbot for commit 6e634c4. This will update automatically on new commits. Configure here.}

metamaskbot · 2025-11-04T09:27:18Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (2 files, +67 -105)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 components/
      - 📁 confirm/
        
        📁 info/
        
        📁 hooks/
        
        📄 useTokenDetails.test.ts +48 -92
        
        📄 useTokenDetails.ts +19 -13

metamaskbot · 2025-11-04T10:10:42Z

Builds ready [c825b20]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1246 ± 86 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1246	1089	1457	86	1301	1418
			load	1068	933	1282	79	1135	1194
			domContentLoaded	1061	906	1274	80	1130	1189
			domInteractive	21	14	88	13	18	52
			firstPaint	633	82	1281	427	1049	1183
			backgroundConnect	233	219	331	12	236	247
			firstReactRender	26	19	53	7	27	43
			getState	22	7	100	12	25	39
			initialActions	6	1	51	7	7	16
			loadScripts	836	670	1057	79	909	965
			setupStore	11	6	22	3	12	17
			numNetworkReqs	13	6	75	19	6	72
	Browserify	Power User Home	uiStartup	2007	1770	2717	328	2465	2717
			load	1026	887	1347	183	1337	1347
			domContentLoaded	1018	882	1334	181	1327	1334
			domInteractive	28	15	84	21	42	84
			firstPaint	583	88	1369	436	931	1369
			backgroundConnect	236	218	266	15	248	266
			firstReactRender	27	24	30	2	28	30
			getState	175	155	230	18	188	230
			initialActions	5	2	13	3	8	13
			loadScripts	794	669	1097	174	1092	1097
			setupStore	11	9	27	4	12	27
			numNetworkReqs	167	101	312	87	293	312
	Webpack	Standard Home	uiStartup	817	690	1154	86	829	1038
			load	596	548	933	74	589	803
			domContentLoaded	589	543	911	71	582	787
			domInteractive	16	11	59	8	14	36
			firstPaint	188	55	914	185	189	713
			backgroundConnect	24	11	62	12	26	54
			firstReactRender	29	18	69	8	33	38
			getState	10	6	16	2	12	14
			initialActions	4	0	36	5	5	9
			loadScripts	586	541	899	68	580	776
			setupStore	11	6	22	3	12	18
			numNetworkReqs	13	6	74	19	8	71
	Webpack	Power User Home	uiStartup	1328	1120	1875	252	1611	1875
			load	662	564	1023	142	836	1023
			domContentLoaded	638	554	980	125	777	980
			domInteractive	27	13	121	28	34	121
			firstPaint	360	80	816	232	570	816
			backgroundConnect	70	17	243	74	161	243
			firstReactRender	26	23	32	2	26	32
			getState	148	109	188	20	157	188
			initialActions	4	1	13	4	4	13
			loadScripts	633	552	968	121	766	968
			setupStore	14	6	27	7	24	27
			numNetworkReqs	184	101	277	65	248	277
Firefox	Browserify	Standard Home	uiStartup	1550	1273	1964	118	1607	1756
			load	1312	1102	1499	87	1385	1465
			domContentLoaded	1311	1101	1499	87	1385	1465
			domInteractive	123	36	394	53	130	229
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	25	145	24	51	123
			firstReactRender	27	22	52	5	28	41
			getState	9	4	182	18	8	17
			initialActions	4	2	16	3	5	12
			loadScripts	1281	1081	1461	84	1348	1418
			setupStore	14	7	60	8	15	33
			numNetworkReqs	12	6	63	15	7	59
	Browserify	Power User Home	uiStartup	2615	2193	3625	463	3107	3625
			load	1429	1155	1969	244	1692	1969
			domContentLoaded	1428	1154	1968	244	1692	1968
			domInteractive	231	83	671	203	476	671
			firstPaint	-	-	-	-	-	-
			backgroundConnect	123	34	444	121	246	444
			firstReactRender	44	31	60	8	52	60
			getState	139	106	190	24	147	190
			initialActions	9	1	38	10	16	38
			loadScripts	1395	1133	1929	235	1651	1929
			setupStore	43	6	179	51	62	179
			numNetworkReqs	152	68	346	101	232	346
	Webpack	Standard Home	uiStartup	1565	1396	2146	159	1597	1989
			load	1336	1187	1686	110	1385	1596
			domContentLoaded	1336	1186	1686	110	1385	1595
			domInteractive	98	31	291	38	113	160
			firstPaint	-	-	-	-	-	-
			backgroundConnect	51	25	211	32	56	116
			firstReactRender	27	21	73	9	27	36
			getState	9	3	183	19	7	16
			initialActions	5	1	32	6	4	25
			loadScripts	1303	1170	1601	94	1349	1511
			setupStore	16	5	87	17	14	70
			numNetworkReqs	13	6	73	18	7	69
	Webpack	Power User Home	uiStartup	2585	2203	3547	322	2812	3547
			load	1550	1278	1845	177	1753	1845
			domContentLoaded	1550	1278	1844	177	1753	1844
			domInteractive	181	48	450	125	302	450
			firstPaint	-	-	-	-	-	-
			backgroundConnect	93	33	285	75	129	285
			firstReactRender	44	30	71	12	50	71
			getState	151	78	249	50	196	249
			initialActions	28	1	178	50	19	178
			loadScripts	1519	1255	1806	169	1705	1806
			setupStore	30	6	82	21	38	82
			numNetworkReqs	158	66	323	80	249	323

📊 Page Load Benchmark Results

Current Commit: c825b20 | Date: 11/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 712ms (±36ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±10ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	38ms	1.00s	1.32s	1.05s	1.32s
domContentLoaded	712ms	36ms	695ms	988ms	734ms	988ms
firstPaint	74ms	10ms	60ms	144ms	92ms	144ms
firstContentfulPaint	74ms	10ms	60ms	144ms	92ms	144ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: -127 Bytes (0%)
common: 10 Bytes (0%)

ui/pages/confirmations/components/confirm/info/hooks/useTokenDetails.ts

metamaskbot · 2025-11-04T15:42:55Z

Builds ready [ce11e57]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1211 ± 83 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1211	1065	1457	83	1250	1398
			load	1032	912	1229	71	1073	1152
			domContentLoaded	1025	906	1217	70	1067	1144
			domInteractive	20	13	72	12	17	57
			firstPaint	641	113	1241	407	1030	1165
			backgroundConnect	228	214	271	8	231	241
			firstReactRender	25	17	47	6	26	38
			getState	20	6	67	10	22	39
			initialActions	7	0	65	8	8	24
			loadScripts	804	688	990	69	846	922
			setupStore	10	6	34	4	11	17
			numNetworkReqs	13	6	71	19	6	70
	Browserify	Power User Home	uiStartup	1973	1768	3180	340	1979	3180
			load	1016	897	1636	188	1125	1636
			domContentLoaded	1009	892	1621	186	1115	1621
			domInteractive	24	15	76	15	20	76
			firstPaint	752	158	1633	459	1125	1633
			backgroundConnect	241	220	314	22	248	314
			firstReactRender	28	25	35	3	29	35
			getState	174	157	235	19	181	235
			initialActions	5	1	19	4	8	19
			loadScripts	782	671	1321	169	897	1321
			setupStore	10	8	14	2	12	14
			numNetworkReqs	146	101	307	72	234	307
	Webpack	Standard Home	uiStartup	830	702	1094	88	837	1063
			load	605	557	860	74	603	828
			domContentLoaded	598	553	843	71	591	817
			domInteractive	16	12	63	9	14	39
			firstPaint	205	60	852	193	194	744
			backgroundConnect	25	12	74	13	30	57
			firstReactRender	29	18	77	9	34	39
			getState	11	5	39	4	12	15
			initialActions	4	1	28	4	4	9
			loadScripts	594	551	833	69	588	806
			setupStore	11	5	29	4	13	16
			numNetworkReqs	13	6	76	19	8	69
	Webpack	Power User Home	uiStartup	1325	1136	1942	272	1518	1942
			load	667	563	1148	172	799	1148
			domContentLoaded	651	552	1070	159	775	1070
			domInteractive	37	12	167	49	43	167
			firstPaint	331	68	1150	304	564	1150
			backgroundConnect	52	10	312	75	88	312
			firstReactRender	26	24	31	1	26	31
			getState	145	109	158	16	155	158
			initialActions	4	1	16	5	7	16
			loadScripts	647	550	1060	155	765	1060
			setupStore	16	6	47	12	25	47
			numNetworkReqs	143	97	279	66	199	279
Firefox	Browserify	Standard Home	uiStartup	1466	1273	1966	118	1508	1706
			load	1254	1084	1775	104	1294	1388
			domContentLoaded	1254	1084	1775	104	1294	1388
			domInteractive	124	34	397	63	129	305
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	26	172	20	49	93
			firstReactRender	25	21	42	3	26	29
			getState	8	4	191	19	6	11
			initialActions	4	1	44	5	4	10
			loadScripts	1227	1066	1752	102	1266	1364
			setupStore	12	6	49	8	12	31
			numNetworkReqs	12	6	66	15	7	58
	Browserify	Power User Home	uiStartup	2459	2185	3141	291	2551	3141
			load	1397	1183	1870	190	1606	1870
			domContentLoaded	1397	1183	1869	189	1605	1869
			domInteractive	227	76	770	206	328	770
			firstPaint	-	-	-	-	-	-
			backgroundConnect	111	31	554	127	140	554
			firstReactRender	45	31	92	16	52	92
			getState	121	83	179	28	141	179
			initialActions	11	1	84	20	13	84
			loadScripts	1364	1148	1844	185	1530	1844
			setupStore	37	9	138	38	55	138
			numNetworkReqs	137	70	312	72	191	312
	Webpack	Standard Home	uiStartup	1596	1388	2092	143	1626	1956
			load	1356	1184	1679	100	1401	1574
			domContentLoaded	1356	1184	1679	99	1401	1573
			domInteractive	100	31	337	40	109	177
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	21	146	26	53	117
			firstReactRender	29	23	78	7	29	39
			getState	10	4	136	19	7	20
			initialActions	5	1	31	5	4	14
			loadScripts	1327	1168	1597	90	1382	1516
			setupStore	17	7	182	21	15	52
			numNetworkReqs	12	6	67	16	8	63
	Webpack	Power User Home	uiStartup	2689	2371	3455	274	2876	3455
			load	1629	1395	1954	173	1798	1954
			domContentLoaded	1628	1394	1954	173	1797	1954
			domInteractive	190	47	481	138	381	481
			firstPaint	-	-	-	-	-	-
			backgroundConnect	93	29	255	68	140	255
			firstReactRender	46	31	107	23	45	107
			getState	128	77	204	35	170	204
			initialActions	6	1	25	6	9	25
			loadScripts	1592	1366	1904	165	1762	1904
			setupStore	28	7	72	21	45	72
			numNetworkReqs	137	66	326	88	200	326

📊 Page Load Benchmark Results

Current Commit: ce11e57 | Date: 11/4/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
domContentLoaded-> current mean value: 716ms (±37ms) 🟢 | historical mean value: 718ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	40ms	1.00s	1.32s	1.06s	1.32s
domContentLoaded	716ms	37ms	694ms	991ms	743ms	991ms
firstPaint	76ms	13ms	60ms	188ms	88ms	188ms
firstContentfulPaint	76ms	13ms	60ms	188ms	88ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: -127 Bytes (0%)
common: 10 Bytes (0%)

ui/pages/confirmations/components/confirm/info/hooks/useTokenDetails.ts

metamaskbot · 2025-11-05T09:14:50Z

Builds ready [6e634c4]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1213 ± 86 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1213	1072	1430	86	1275	1374
			load	1042	924	1219	80	1103	1180
			domContentLoaded	1034	857	1213	82	1097	1165
			domInteractive	21	14	77	13	18	56
			firstPaint	607	72	1227	414	1017	1174
			backgroundConnect	230	217	337	14	231	255
			firstReactRender	24	17	53	5	25	33
			getState	20	7	45	8	22	39
			initialActions	6	1	70	8	7	18
			loadScripts	811	634	991	81	878	947
			setupStore	10	6	22	3	11	14
			numNetworkReqs	13	6	76	20	6	74
	Browserify	Power User Home	uiStartup	2060	1794	3454	432	2320	3454
			load	1038	896	1555	200	1242	1555
			domContentLoaded	1030	889	1550	198	1237	1550
			domInteractive	32	15	89	24	56	89
			firstPaint	734	183	1352	385	937	1352
			backgroundConnect	246	223	309	22	263	309
			firstReactRender	27	25	33	2	28	33
			getState	182	156	230	19	191	230
			initialActions	7	2	37	8	6	37
			loadScripts	800	667	1268	188	1018	1268
			setupStore	16	9	28	7	27	28
			numNetworkReqs	175	104	374	95	290	374
	Webpack	Standard Home	uiStartup	838	717	1236	95	842	1088
			load	612	557	981	82	603	852
			domContentLoaded	604	551	961	78	593	825
			domInteractive	16	11	65	10	14	46
			firstPaint	211	59	965	208	198	756
			backgroundConnect	25	10	71	13	27	59
			firstReactRender	28	18	51	7	34	36
			getState	10	5	19	3	12	15
			initialActions	3	0	16	3	4	10
			loadScripts	601	549	949	76	590	814
			setupStore	11	5	23	3	13	18
			numNetworkReqs	13	6	75	19	8	72
	Webpack	Power User Home	uiStartup	1312	1161	1850	227	1335	1850
			load	658	575	997	128	805	997
			domContentLoaded	634	563	869	101	765	869
			domInteractive	24	12	79	19	43	79
			firstPaint	349	63	872	291	576	872
			backgroundConnect	52	10	188	58	67	188
			firstReactRender	27	25	40	3	27	40
			getState	143	65	163	26	159	163
			initialActions	3	1	25	6	3	25
			loadScripts	629	561	858	97	752	858
			setupStore	14	6	33	9	25	33
			numNetworkReqs	164	99	282	66	233	282
Firefox	Browserify	Standard Home	uiStartup	1519	1305	2108	132	1580	1736
			load	1285	1125	1509	92	1356	1465
			domContentLoaded	1285	1125	1509	92	1356	1465
			domInteractive	122	38	412	49	131	217
			firstPaint	-	-	-	-	-	-
			backgroundConnect	50	27	154	25	56	118
			firstReactRender	27	21	75	7	27	40
			getState	9	4	187	19	7	17
			initialActions	4	2	23	3	4	12
			loadScripts	1253	1106	1490	85	1324	1398
			setupStore	15	7	225	22	15	28
			numNetworkReqs	12	6	62	15	8	60
	Browserify	Power User Home	uiStartup	2439	2107	3180	270	2522	3180
			load	1356	1158	1644	163	1599	1644
			domContentLoaded	1356	1158	1643	163	1599	1643
			domInteractive	213	85	530	160	456	530
			firstPaint	-	-	-	-	-	-
			backgroundConnect	123	28	441	114	200	441
			firstReactRender	39	30	46	5	45	46
			getState	132	80	208	32	155	208
			initialActions	9	1	32	9	12	32
			loadScripts	1302	1091	1605	162	1430	1605
			setupStore	27	5	81	22	43	81
			numNetworkReqs	142	68	331	86	222	331
	Webpack	Standard Home	uiStartup	1678	1513	2408	155	1698	1969
			load	1410	1271	1705	89	1450	1594
			domContentLoaded	1410	1271	1705	89	1450	1594
			domInteractive	101	36	181	26	114	156
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	25	159	26	57	110
			firstReactRender	31	24	74	8	31	41
			getState	10	3	111	17	7	37
			initialActions	7	1	186	19	4	31
			loadScripts	1377	1242	1620	82	1420	1537
			setupStore	18	7	206	23	15	53
			numNetworkReqs	13	6	69	18	7	65
	Webpack	Power User Home	uiStartup	2580	2186	3349	313	2736	3349
			load	1531	1239	2027	194	1698	2027
			domContentLoaded	1530	1238	2026	194	1698	2026
			domInteractive	144	38	427	103	194	427
			firstPaint	-	-	-	-	-	-
			backgroundConnect	103	31	360	90	142	360
			firstReactRender	43	31	53	8	51	53
			getState	128	74	196	39	175	196
			initialActions	13	1	81	21	8	81
			loadScripts	1487	1219	1978	180	1636	1978
			setupStore	46	6	173	47	57	173
			numNetworkReqs	199	67	340	84	252	340

📊 Page Load Benchmark Results

Current Commit: 6e634c4 | Date: 11/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
domContentLoaded-> current mean value: 714ms (±37ms) 🟢 | historical mean value: 719ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	1.00s	1.33s	1.06s	1.33s
domContentLoaded	714ms	37ms	693ms	1.01s	737ms	1.01s
firstPaint	75ms	10ms	60ms	156ms	84ms	156ms
firstContentfulPaint	75ms	10ms	60ms	156ms	84ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.92 KiB (0.04%)
ui: 23.33 KiB (0.33%)
common: 1.33 KiB (0.02%)

gauthierpetetin · 2025-11-05T17:01:41Z

Hi @OGPoyraz , what would be the user-facing CHANGELOG entry for this PR?

Fix unknown token issue when nonEVM selected in network manager

658c741

OGPoyraz requested a review from a team as a code owner November 4, 2025 09:26

metamaskbot added the team-confirmations Push issues to confirmations team label Nov 4, 2025

github-actions bot added the size-M label Nov 4, 2025

This comment was marked as outdated.

Sign in to view

vinistevam previously approved these changes Nov 4, 2025

View reviewed changes

Merge branch 'main' into ogp/37428

c825b20

jpuri previously approved these changes Nov 4, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into ogp/37428

ce11e57

OGPoyraz enabled auto-merge November 4, 2025 15:19

cursor bot reviewed Nov 4, 2025

View reviewed changes

ui/pages/confirmations/components/confirm/info/hooks/useTokenDetails.ts Show resolved Hide resolved

Update tests

81e64cd

OGPoyraz dismissed stale reviews from jpuri and vinistevam via 81e64cd November 5, 2025 08:40

cursor bot reviewed Nov 5, 2025

View reviewed changes

ui/pages/confirmations/components/confirm/info/hooks/useTokenDetails.ts Show resolved Hide resolved

Update

6e634c4

cursor bot reviewed Nov 5, 2025

View reviewed changes

ui/pages/confirmations/components/confirm/info/hooks/useTokenDetails.ts Show resolved Hide resolved

jpuri approved these changes Nov 5, 2025

View reviewed changes

vinistevam approved these changes Nov 5, 2025

View reviewed changes

OGPoyraz added this pull request to the merge queue Nov 5, 2025

Merged via the queue into main with commit 3045d76 Nov 5, 2025
173 checks passed

OGPoyraz deleted the ogp/37428 branch November 5, 2025 10:36

github-actions bot locked and limited conversation to collaborators Nov 5, 2025

metamaskbot added the release-13.9.0 Issue or pull request that will be included in release 13.9.0 label Nov 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: cp-13.8.0 Fix unknown token issue when nonEVM selected in network manager #37491

fix: cp-13.8.0 Fix unknown token issue when nonEVM selected in network manager #37491

OGPoyraz commented Nov 4, 2025 •

edited by cursor bot

Loading

Uh oh!

metamaskbot commented Nov 4, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Nov 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbot commented Nov 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 5, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

gauthierpetetin commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix: cp-13.8.0 Fix unknown token issue when nonEVM selected in network manager #37491

fix: cp-13.8.0 Fix unknown token issue when nonEVM selected in network manager #37491

Conversation

OGPoyraz commented Nov 4, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

metamaskbot commented Nov 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

metamaskbot commented Nov 4, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 5, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

gauthierpetetin commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OGPoyraz commented Nov 4, 2025 •

edited by cursor bot

Loading

metamaskbot commented Nov 4, 2025 •

edited

Loading