test: Skip tests that will fail once BIP44 is turned on #37832
+47
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/wallet-integrations (2 files, +6 -3)
|
davibroc
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
test/e2e/tests/confirmations/transactions/gas-fee-tokens-eip-7702-sponsored.spec.ts
Show resolved
Hide resolved
davibroc
added
the
no-changelog
gantunesr
reviewed
Nov 18, 2025
Member
gantunesr
left a comment
gantunesr
left a comment
There was a problem hiding this comment.
Looks good! @owencraston will send a message to all team to update these E2E tests, once that is done we can approve this PR
gantunesr
reviewed
Nov 18, 2025
| const SHORTENED_EOA_ADDRESS = '0xd8dA6...96045'; | ||
| const DEFAULT_WATCHED_ACCOUNT_NAME = 'Watched Account 1'; | ||
|
|
||
| describe('Account-watcher snap', function (this: Suite) { |
Member
davibroc
force-pushed
the
test/skip-tests-bip44
branch
from
14c3ce3 to
0d039de
Compare
davibroc
changed the title
Collaborator
Builds ready [0d039de]
UI Startup Metrics (1271 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
ffmcgee725
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests were skipped :
Creating a watch account with EOA address is no longer possible with current UI
flask/create-watch-account.spec.ts#37563
The following e2e test script will fail with message
Error invoking methodflask/multichain-api/non-evm/wallet_invokeMethod.spec.ts#37691
Tthe script tries to create a wallet session from the Mutlichin API test dapp I see the confirmation screen crash with error
Invalid CAIP chain IDflask/multichain-api/evm/wallet_invokeMethod.spec.ts#37821
These tests fail with with uncaught exception
flask/solana-wallet-standard/transaction_sol.spec.tsflask/solana-wallet-standard/transaction_wsol.spec.tsflask/solana-wallet-standard/signMessage.spec.ts#37690
When sending a transaction to dApp with BIP44 the confirmation crashes
test/e2e/flask/user-operations.spec.ts#37823
Skipping these tests becasue on BIP44 EIP-7702 not supported on chain: 0x539
test/e2e/tests/confirmations/transactions/eip7702-eip5792-upgrade-account.spec.tsWhen
eth_sendTransactionrequest is sent and the gas fee are paid in USDC or by Metamask, that's not showing on the confirmation dialogconfirmations/transactions/gas-fee-tokens-eip-7702.spec.tsconfirmations/transactions/gas-fee-tokens-eip-7702-sponsored.spec.ts#37677
The problem with these Solana tests is that mocking Solana network responses no longer works.
test/e2e/tests/send/send-solana.spec.tstest/e2e/tests/solana/check-balance.spec.tstest/e2e/tests/solana/send-flow.spec.tstest/e2e/tests/solana/transaction-activity-list.spec.ts#37824
With BIP44 tokens in the wallet cannot be sorted (might be in production too)
tokens/token-sort.spec.ts#37687
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Marks multiple E2E suites/tests as skipped across watch accounts, Multichain API, Solana flows, User Operations, EIP-7702, and token sorting due to known issues/feature-flag conflicts.
test/e2e/flask/create-watch-account.spec.ts(EOA watch flows) due to BIP44 limitation.EIP-5792 Methodsblock inflask/multichain-api/evm/wallet_invokeMethod.spec.ts(EIP-7702 crash).flask/multichain-api/non-evm/wallet_invokeMethod.spec.ts(Solana signIn/signAndSend).signMessage.spec.ts,transaction_sol.spec.ts,transaction_wsol.spec.ts(exceptions under BIP44).test/e2e/flask/user-operations.spec.ts(confirmation crash).eip7702-eip5792-upgrade-account.spec.ts(unsupported on chain 0x539).gas-fee-tokens-eip-7702.spec.tsandgas-fee-tokens-eip-7702-sponsored.spec.ts(fee display issues).send-solana.spec.ts, most ofcheck-balance.spec.ts(non-zero cases),send-flow.spec.ts,transaction-activity-list.spec.ts(mocking disabled with BIP44).tokens/token-sort.spec.ts(alphabetical sorting bug).Written by Cursor Bugbot for commit 0d039de. This will update automatically on new commits. Configure here.