test: Add new vault #37954
Open
test: Add new vault #37954
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +7 -0)
|
Collaborator
Builds ready [ea2bea2]
UI Startup Metrics (1216 ± 91 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| q// This SRP has 30 accounts each with a Solana account | ||
| const TEST_SRP = | ||
| 'stock grab suspect keep column cover plate grape assault patrol pistol wire'; | ||
|
|
There was a problem hiding this comment.
Bug: Fix Constant Mismatch
A new TEST_SRP constant is defined but never used. Line 45 still references the undefined E2E_SRP instead, which will cause a runtime error because E2E_SRP was removed from the imports. The code should use the TEST_SRP constant instead of E2E_SRP on line 45.
Collaborator
Builds ready [782b59b]
UI Startup Metrics (1250 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davibroc
added
the
no-changelog
davibroc
force-pushed
the
test/fix-test-webpack
branch
from
5984f05 to
fb3bbe6
Compare
Collaborator
Builds ready [fb3bbe6]
UI Startup Metrics (1267 ± 95 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds
withKeyringThirtyAccounts()toFixtureBuilderwith a prebuilt 30-account vault and updates wallet state generator with a test SRP and new imports.test/e2e/fixture-builder.js:withKeyringThirtyAccounts()to setKeyringControllervaultprepopulated with 30 accounts.app/scripts/fixtures/generate-wallet-state.js:uuid,sha256FromString); removeE2E_SRPimport.Written by Cursor Bugbot for commit fb3bbe6. This will update automatically on new commits. Configure here.