ci: Improve bundle size warning #37958

Gudahtt · 2025-11-18T22:14:41Z

Description

The warning shown on metamaskbot comments abount bundle size can be misleading. It only considers the background bundle size (despite the UI being far more impactful for performance), and it's too sensitive to miniscule changes in bundle size that don't have any real impact.

The warning has been adjusted to consider significant changes in bundle size for UI or background, and to suppress any warning when the bundle size change is under one KB.

Changelog

CHANGELOG entry: null

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-11-18T22:41:28Z

Builds ready [75d24cb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1235 ± 100 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1235	1079	1703	100	1299	1385
			load	1063	909	1485	92	1133	1204
			domContentLoaded	1055	903	1470	90	1122	1184
			domInteractive	23	14	83	16	20	66
			firstPaint	716	80	1503	420	1077	1169
			backgroundConnect	234	220	363	15	236	251
			firstReactRender	28	19	95	10	28	47
			getState	22	8	61	9	27	39
			initialActions	1	0	3	1	1	2
			loadScripts	828	677	1249	90	896	956
			setupStore	10	5	33	4	11	18
			numNetworkReqs	13	6	76	20	6	71
	Browserify	Power User Home	uiStartup	2099	1616	3516	411	2222	3516
			load	1055	880	1725	225	1250	1725
			domContentLoaded	1034	864	1706	225	1241	1706
			domInteractive	55	18	178	58	117	178
			firstPaint	727	177	1715	437	978	1715
			backgroundConnect	204	180	250	16	210	250
			firstReactRender	75	45	137	22	85	137
			getState	238	145	422	68	266	422
			initialActions	1	0	4	1	2	4
			loadScripts	853	687	1492	217	1060	1492
			setupStore	27	12	53	11	36	53
			numNetworkReqs	120	83	184	33	159	184
	Webpack	Standard Home	uiStartup	788	658	1177	90	809	1017
			load	562	502	932	73	560	746
			domContentLoaded	555	497	916	69	556	732
			domInteractive	17	11	60	11	14	49
			firstPaint	216	53	919	220	174	736
			backgroundConnect	26	12	63	12	31	55
			firstReactRender	32	19	290	27	35	40
			getState	11	5	32	5	12	23
			initialActions	1	0	3	1	1	1
			loadScripts	552	495	908	68	554	724
			setupStore	11	5	26	4	13	16
			numNetworkReqs	14	6	76	20	8	73
	Webpack	Power User Home	uiStartup	1042	905	1584	202	1152	1584
			load	655	565	967	123	786	967
			domContentLoaded	637	555	870	103	772	870
			domInteractive	34	12	143	38	58	143
			firstPaint	305	69	874	284	634	874
			backgroundConnect	44	9	225	61	34	225
			firstReactRender	41	37	45	2	42	45
			getState	133	93	150	20	147	150
			initialActions	1	0	1	0	1	1
			loadScripts	633	553	861	100	761	861
			setupStore	12	6	31	8	24	31
			numNetworkReqs	77	63	129	20	84	129
Firefox	Browserify	Standard Home	uiStartup	1531	1356	2571	172	1548	1866
			load	1286	1154	1853	114	1303	1519
			domContentLoaded	1286	1153	1852	114	1303	1519
			domInteractive	53	34	198	32	45	132
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	20	237	27	46	69
			firstReactRender	28	23	43	4	28	40
			getState	13	8	194	19	12	23
			initialActions	2	0	3	1	2	2
			loadScripts	1259	1134	1768	102	1283	1489
			setupStore	14	8	78	11	13	41
			numNetworkReqs	12	6	73	16	7	59
	Browserify	Power User Home	uiStartup	3164	2501	4389	509	3635	4389
			load	1562	1301	2174	295	1875	2174
			domContentLoaded	1562	1301	2174	295	1874	2174
			domInteractive	231	65	653	182	298	653
			firstPaint	-	-	-	-	-	-
			backgroundConnect	561	117	1238	348	812	1238
			firstReactRender	75	51	111	19	94	111
			getState	162	97	385	62	174	385
			initialActions	3	1	7	1	3	7
			loadScripts	1499	1261	2124	293	1741	2124
			setupStore	128	38	559	153	106	559
			numNetworkReqs	130	78	243	60	223	243
	Webpack	Standard Home	uiStartup	1616	1418	2298	183	1623	2145
			load	1364	1197	1758	123	1374	1699
			domContentLoaded	1363	1197	1758	123	1374	1699
			domInteractive	54	30	253	34	61	116
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	21	221	33	50	138
			firstReactRender	34	25	144	16	32	80
			getState	14	7	192	20	12	46
			initialActions	2	0	7	1	2	3
			loadScripts	1331	1172	1703	107	1347	1589
			setupStore	17	6	210	24	11	53
			numNetworkReqs	13	6	71	17	7	65
	Webpack	Power User Home	uiStartup	3371	2681	4277	523	3999	4277
			load	1700	1467	2147	210	1931	2147
			domContentLoaded	1700	1467	2147	210	1930	2147
			domInteractive	235	64	569	167	454	569
			firstPaint	-	-	-	-	-	-
			backgroundConnect	475	115	1096	324	881	1096
			firstReactRender	88	58	137	23	101	137
			getState	175	113	411	65	179	411
			initialActions	3	2	9	2	3	9
			loadScripts	1648	1406	2107	218	1904	2107
			setupStore	121	51	455	95	136	455
			numNetworkReqs	126	74	229	53	174	229

📊 Page Load Benchmark Results

Current Commit: 75d24cb | Date: 11/18/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 724ms (±35ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	39ms	1.00s	1.32s	1.08s	1.32s
domContentLoaded	724ms	35ms	696ms	976ms	761ms	976ms
firstPaint	76ms	13ms	60ms	188ms	84ms	188ms
firstContentfulPaint	76ms	13ms	60ms	188ms	84ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

metamaskbot · 2025-11-19T14:31:39Z

Builds ready [e0eec9d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1208 ± 87 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1208	1057	1531	87	1256	1361
			load	1035	910	1334	81	1095	1160
			domContentLoaded	1028	907	1328	81	1091	1152
			domInteractive	23	13	100	18	19	76
			firstPaint	529	92	1190	395	985	1156
			backgroundConnect	209	194	322	14	211	225
			firstReactRender	28	19	59	9	32	48
			getState	31	17	62	7	34	43
			initialActions	1	0	3	1	1	2
			loadScripts	826	684	1106	81	892	951
			setupStore	10	7	32	4	11	16
			numNetworkReqs	13	6	74	20	6	73
	Browserify	Power User Home	uiStartup	1863	1557	2586	247	2006	2410
			load	997	869	1586	160	995	1439
			domContentLoaded	983	863	1571	158	973	1431
			domInteractive	35	16	209	37	29	139
			firstPaint	529	95	1580	403	933	1384
			backgroundConnect	220	199	246	10	226	240
			firstReactRender	80	49	231	22	85	107
			getState	172	129	360	42	191	280
			initialActions	1	0	5	1	1	2
			loadScripts	778	666	1356	155	768	1213
			setupStore	21	9	61	10	29	36
			numNetworkReqs	98	65	201	32	104	185
	Webpack	Standard Home	uiStartup	857	706	1267	89	881	1033
			load	602	548	949	67	609	764
			domContentLoaded	596	542	928	63	604	749
			domInteractive	18	12	77	13	15	53
			firstPaint	189	61	933	178	186	579
			backgroundConnect	26	12	83	17	26	74
			firstReactRender	33	20	73	10	38	54
			getState	20	12	44	6	23	28
			initialActions	1	0	3	1	1	1
			loadScripts	593	540	919	62	602	741
			setupStore	12	6	33	4	15	18
			numNetworkReqs	13	6	77	20	8	71
	Webpack	Power User Home	uiStartup	1392	1193	2282	225	1541	1885
			load	679	587	1337	149	669	1047
			domContentLoaded	657	574	1294	141	638	1010
			domInteractive	32	13	197	42	20	155
			firstPaint	361	66	1299	295	601	1005
			backgroundConnect	53	17	163	37	85	129
			firstReactRender	80	44	134	13	85	99
			getState	157	112	225	20	170	201
			initialActions	1	0	2	0	1	2
			loadScripts	654	571	1286	139	636	1001
			setupStore	19	6	63	14	33	40
			numNetworkReqs	124	67	264	50	142	235
Firefox	Browserify	Standard Home	uiStartup	1242	1088	1647	124	1318	1504
			load	1048	924	1242	90	1120	1224
			domContentLoaded	1047	924	1241	90	1116	1224
			domInteractive	57	30	225	35	82	133
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	16	155	24	41	92
			firstReactRender	22	17	47	5	22	35
			getState	10	6	35	6	13	24
			initialActions	1	0	2	0	1	2
			loadScripts	1024	909	1212	82	1084	1188
			setupStore	11	6	64	8	11	22
			numNetworkReqs	12	6	76	16	7	58
	Browserify	Power User Home	uiStartup	2792	2122	3720	329	2975	3559
			load	1239	1001	1770	191	1253	1691
			domContentLoaded	1238	1001	1770	191	1253	1691
			domInteractive	152	35	631	140	161	552
			firstPaint	-	-	-	-	-	-
			backgroundConnect	279	33	1054	282	487	903
			firstReactRender	88	37	161	20	98	122
			getState	249	92	911	245	198	864
			initialActions	2	1	8	1	2	6
			loadScripts	1184	981	1734	172	1188	1643
			setupStore	100	10	795	154	97	628
			numNetworkReqs	96	52	208	40	97	198
	Webpack	Standard Home	uiStartup	1531	1351	1947	136	1569	1832
			load	1293	1113	1613	109	1350	1524
			domContentLoaded	1292	1113	1613	109	1350	1523
			domInteractive	79	28	232	48	101	182
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	22	135	22	49	113
			firstReactRender	31	22	81	9	31	42
			getState	13	6	60	10	12	48
			initialActions	1	0	3	1	2	2
			loadScripts	1263	1096	1532	102	1324	1469
			setupStore	16	7	78	15	13	52
			numNetworkReqs	13	6	71	18	7	67
	Webpack	Power User Home	uiStartup	2812	2021	3802	343	2993	3480
			load	1362	1077	1844	179	1491	1701
			domContentLoaded	1361	1076	1844	179	1490	1700
			domInteractive	127	29	535	122	135	462
			firstPaint	-	-	-	-	-	-
			backgroundConnect	167	28	872	192	180	617
			firstReactRender	87	40	191	21	95	121
			getState	290	86	899	282	340	874
			initialActions	3	0	46	6	2	7
			loadScripts	1330	1061	1819	178	1430	1672
			setupStore	118	6	788	180	107	677
			numNetworkReqs	100	64	239	43	123	201

📊 Page Load Benchmark Results

Current Commit: e0eec9d | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±49ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 727ms (±47ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±21ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	49ms	1.02s	1.45s	1.07s	1.45s
domContentLoaded	727ms	47ms	706ms	1.13s	758ms	1.13s
firstPaint	79ms	21ms	60ms	284ms	84ms	284ms
firstContentfulPaint	79ms	21ms	60ms	284ms	84ms	284ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 53 Bytes (0%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

The warning shown on `metamaskbot` comments abount bundle size can be misleading. It only considers the background bundle size (despite the UI being far more impactful for performance), and it's too sensitive to miniscule changes in bundle size that don't have any real impact. The warning has been adjusted to consider significant changes in bundle size for UI or background, and to suppress any warning when the bundle size change is under one KB.

metamaskbot · 2025-11-19T15:35:41Z

Builds ready [127cf1d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1230 ± 90 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1230	1066	1547	90	1298	1385
			load	1049	907	1325	83	1112	1163
			domContentLoaded	1043	902	1313	82	1106	1156
			domInteractive	24	14	123	21	20	84
			firstPaint	484	75	1324	390	1018	1126
			backgroundConnect	209	196	261	11	211	242
			firstReactRender	25	18	46	6	27	38
			getState	31	17	57	8	35	47
			initialActions	1	0	3	1	1	1
			loadScripts	840	687	1083	83	905	959
			setupStore	11	7	32	4	11	22
			numNetworkReqs	13	6	74	19	6	71
	Browserify	Power User Home	uiStartup	1833	1518	3404	301	1980	2521
			load	962	841	2057	190	949	1432
			domContentLoaded	947	830	2044	189	928	1417
			domInteractive	35	16	236	40	28	140
			firstPaint	684	173	2053	390	904	1421
			backgroundConnect	204	183	248	13	210	230
			firstReactRender	77	43	116	13	86	98
			getState	180	138	351	41	199	279
			initialActions	1	0	4	1	1	2
			loadScripts	759	651	1810	183	742	1221
			setupStore	19	9	61	11	25	44
			numNetworkReqs	97	66	202	33	105	190
	Webpack	Standard Home	uiStartup	853	704	1194	90	868	1024
			load	605	546	964	82	603	813
			domContentLoaded	598	540	949	79	598	797
			domInteractive	18	11	67	13	15	56
			firstPaint	201	59	960	214	180	772
			backgroundConnect	27	11	76	15	28	71
			firstReactRender	32	19	63	9	38	43
			getState	19	12	35	5	23	27
			initialActions	1	0	4	1	1	2
			loadScripts	595	538	941	77	595	785
			setupStore	12	6	34	4	14	17
			numNetworkReqs	13	6	76	19	8	71
	Webpack	Power User Home	uiStartup	1321	1149	2369	214	1432	1720
			load	651	567	1540	148	650	992
			domContentLoaded	633	553	1390	135	619	965
			domInteractive	30	13	270	41	21	114
			firstPaint	305	59	1395	310	580	970
			backgroundConnect	44	10	223	34	64	110
			firstReactRender	74	43	103	12	80	92
			getState	146	115	191	16	158	176
			initialActions	1	0	2	0	1	1
			loadScripts	630	551	1382	133	616	956
			setupStore	17	6	77	16	26	59
			numNetworkReqs	115	68	241	47	123	225
Firefox	Browserify	Standard Home	uiStartup	1241	1078	1575	102	1305	1463
			load	1052	928	1352	81	1112	1217
			domContentLoaded	1051	928	1352	81	1112	1217
			domInteractive	62	30	232	39	83	136
			firstPaint	-	-	-	-	-	-
			backgroundConnect	37	20	117	19	39	86
			firstReactRender	22	17	44	6	23	35
			getState	10	6	60	8	9	19
			initialActions	1	0	2	1	1	2
			loadScripts	1027	915	1278	74	1079	1159
			setupStore	11	5	101	12	9	26
			numNetworkReqs	12	6	63	14	8	57
	Browserify	Power User Home	uiStartup	2699	1914	3448	318	2920	3238
			load	1213	977	1740	181	1318	1557
			domContentLoaded	1212	976	1740	181	1318	1557
			domInteractive	148	32	610	136	169	523
			firstPaint	-	-	-	-	-	-
			backgroundConnect	192	18	931	200	285	652
			firstReactRender	87	39	137	21	98	130
			getState	277	65	907	274	205	866
			initialActions	2	0	7	2	2	7
			loadScripts	1168	956	1720	177	1250	1531
			setupStore	118	5	787	182	102	746
			numNetworkReqs	97	62	232	42	108	208
	Webpack	Standard Home	uiStartup	1484	1292	1973	135	1529	1803
			load	1249	1119	1576	104	1297	1464
			domContentLoaded	1249	1119	1570	104	1297	1464
			domInteractive	69	30	233	46	91	137
			firstPaint	-	-	-	-	-	-
			backgroundConnect	39	22	126	17	44	73
			firstReactRender	31	21	73	10	33	69
			getState	14	7	161	17	11	44
			initialActions	1	0	3	1	2	3
			loadScripts	1225	1102	1492	99	1278	1438
			setupStore	16	7	95	16	13	50
			numNetworkReqs	13	6	70	18	7	66
	Webpack	Power User Home	uiStartup	2952	2222	3912	372	3211	3633
			load	1452	1168	1939	195	1617	1853
			domContentLoaded	1452	1168	1939	195	1616	1853
			domInteractive	159	32	760	158	171	529
			firstPaint	-	-	-	-	-	-
			backgroundConnect	228	31	1021	222	341	725
			firstReactRender	91	44	175	22	102	128
			getState	284	89	934	282	210	873
			initialActions	4	1	64	8	3	8
			loadScripts	1406	1147	1913	189	1543	1832
			setupStore	116	6	833	175	108	647
			numNetworkReqs	100	57	235	44	115	211

📊 Page Load Benchmark Results

Current Commit: 127cf1d | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±45ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 728ms (±41ms) 🟢 | historical mean value: 723ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	45ms	1.02s	1.39s	1.07s	1.39s
domContentLoaded	728ms	41ms	707ms	1.03s	748ms	1.03s
firstPaint	78ms	12ms	60ms	176ms	84ms	176ms
firstContentfulPaint	78ms	12ms	60ms	176ms	84ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs

background: 53 Bytes (0%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

metamaskbot added the team-core-platform Core Platform team label Nov 18, 2025

Gudahtt force-pushed the improve-bundle-size-message branch from 5fd029c to 75d24cb Compare November 18, 2025 22:15

github-actions bot added the size-S label Nov 18, 2025

Gudahtt force-pushed the improve-bundle-size-message branch from 75d24cb to e0eec9d Compare November 19, 2025 14:00

Gudahtt force-pushed the improve-bundle-size-message branch 2 times, most recently from 5b2433f to 127cf1d Compare November 19, 2025 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: Improve bundle size warning #37958

ci: Improve bundle size warning #37958

Gudahtt commented Nov 18, 2025 •

edited by github-actions bot

Loading

Uh oh!

metamaskbot commented Nov 18, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ci: Improve bundle size warning #37958

Are you sure you want to change the base?

ci: Improve bundle size warning #37958

Conversation

Gudahtt commented Nov 18, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Nov 18, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Gudahtt commented Nov 18, 2025 •

edited by github-actions bot

Loading