Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Nov 19, 2025

Description

Removes the "MetaMask Extension" subtitle in the Open full screen menu
item

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fix: open full screen text

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-684

Manual testing steps

Open main menu, observe Open full screen item

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Removes the “MetaMask Extension” subtitle from the Global Menu’s “Open full screen” item and deletes the unused metamaskExtension i18n key.

  • UI:
    • ui/components/multichain/global-menu/global-menu.tsx: Remove subtitle under openFullScreen menu item; item now shows only t('openFullScreen').
  • i18n:
    • Delete metamaskExtension key from app/_locales/en/messages.json and app/_locales/en_GB/messages.json.

Written by Cursor Bugbot for commit 6f65b2d. This will update automatically on new commits. Configure here.

20f49e6

## **Description**

Removes the "MetaMask Extension" subtitle in the Open full screen menu
item

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/37916?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: fix: open full screen text

## **Related issues**

Fixes: https://consensyssoftware.atlassian.net/browse/CEUX-684

## **Manual testing steps**

Open main menu, observe Open full screen item

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="234" height="53" alt="image"
src="https://github.com/user-attachments/assets/84123d29-6225-4b15-9fc4-1652ecae5971"
/>


### **After**

<img width="233" height="46" alt="image"
src="https://github.com/user-attachments/assets/1e1d6278-3cc2-409a-9df1-b8e1b6b0ad9c"
/>


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Removes the "MetaMask Extension" subtitle from the global menu’s Open
full screen item and deletes its unused i18n keys.
> 
> - **UI (global menu)**:
> - Simplify `Open full screen` menu item by removing the "MetaMask
Extension" subtitle and related `Text` usage in
`ui/components/multichain/global-menu/global-menu.tsx`.
> - **I18n**:
> - Remove unused `metamaskExtension` message from
`app/_locales/en/messages.json` and `app/_locales/en_GB/messages.json`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
dcea031. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github bot requested a review from a team as a code owner November 19, 2025 14:32
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Nov 19, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +0 -7)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 global-menu/
          • 📄 global-menu.tsx +0 -7

@metamaskbot
Copy link
Collaborator

Builds ready [6f65b2d]
UI Startup Metrics (1230 ± 84 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1230106415308412891368
load106893013327711241191
domContentLoaded106292413277711181179
domInteractive2315103182074
firstPaint726163122140610851179
backgroundConnect2322182627236245
firstReactRender28184863142
getState227115152537
initialActions107113
loadScripts836699109078890949
setupStore1162231119
numNetworkReqs1367620673
BrowserifyPower User HomeuiStartup19281658276728120262767
load1095934174722812931747
domContentLoaded1082924171122312861711
domInteractive511815249122152
firstPaint61320517494779921749
backgroundConnect24522827213254272
firstReactRender53456555565
getState19415928841242288
initialActions102012
loadScripts851705146421810531464
setupStore17113251932
numNetworkReqs996918542152185
WebpackStandard HomeuiStartup83870811361008341109
load61156191682608880
domContentLoaded60455689979602855
domInteractive181283151558
firstPaint21959902204200754
backgroundConnect261177133251
firstReactRender3419277263659
getState1062431215
initialActions104111
loadScripts60155488877600845
setupStore1153351217
numNetworkReqs1367419770
WebpackPower User HomeuiStartup1140944208929913442089
load70460010541588801054
domContentLoaded68258810411437911041
domInteractive37141154098115
firstPaint33384946264591946
backgroundConnect561716357132163
firstReactRender44415644656
getState1469419927156199
initialActions101011
loadScripts67858610291397801029
setupStore16631102731
numNetworkReqs826413526123135
FirefoxBrowserifyStandard HomeuiStartup14711301189813115111826
load1236112015258512921401
domContentLoaded1235112015248512921400
domInteractive55332353954159
firstPaint------
backgroundConnect4423234265090
firstReactRender27225562842
getState1073341120
initialActions2027322
loadScripts1209110314567812661372
setupStore166188221256
numNetworkReqs1266315756
BrowserifyPower User HomeuiStartup28982212438068537724380
load14551278188916815951889
domContentLoaded14551278188916815941889
domInteractive19861449124368449
firstPaint------
backgroundConnect3687713134288701313
firstReactRender78561171784117
getState14410419525167195
initialActions217137
loadScripts14101253181116615611811
setupStore11836508117123508
numNetworkReqs1226725671224256
WebpackStandard HomeuiStartup16161427223415616201983
load13631205172310413911608
domContentLoaded13631204172310413911608
domInteractive57302363462126
firstPaint------
backgroundConnect48203223551108
firstReactRender342481113667
getState157214231149
initialActions103122
loadScripts1336118916969713631535
setupStore187139231454
numNetworkReqs1367018768
WebpackPower User HomeuiStartup32102415431353838124313
load16741498201915818722019
domContentLoaded16731498201715818712017
domInteractive20591502133278502
firstPaint------
backgroundConnect3388310663527071066
firstReactRender74521171685117
getState214105516108240516
initialActions213133
loadScripts16251469197715918441977
setupStore19440706212334706
numNetworkReqs1247127168176271
📊 Page Load Benchmark Results

Current Commit: 6f65b2d | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 998ms (±41ms) 🟢 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 691ms (±36ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 998ms 41ms 971ms 1.29s 1.02s 1.29s
domContentLoaded 691ms 36ms 670ms 952ms 708ms 952ms
firstPaint 77ms 12ms 64ms 180ms 88ms 180ms
firstContentfulPaint 77ms 12ms 64ms 180ms 88ms 180ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

@gauthierpetetin gauthierpetetin merged commit ec2a0e6 into release/13.10.0 Nov 19, 2025
173 of 174 checks passed
@gauthierpetetin gauthierpetetin deleted the runway-cherry-pick-13.10.0-1763562766 branch November 19, 2025 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
@metamaskbot metamaskbot added the release-13.10.0 Issue or pull request that will be included in release 13.10.0 label Nov 19, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-13.10.0 on PR, as PR was cherry-picked in branch 13.10.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.10.0 Issue or pull request that will be included in release 13.10.0 team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants