-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: handle api errors on UI during subscription #38090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+407
−221
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
15b795a
feat: handle api errors on UI during subscription
lionellbriones e1dc9fd
Merge branch 'main' into feat/shield-plan-error-handling
lionellbriones b6ab14f
feat: handle redirect to home on e2e
lionellbriones 4df4ceb
Merge branch 'main' into feat/shield-plan-error-handling
lionellbriones 8eccbfc
Merge branch 'main' into feat/shield-plan-error-handling
lionellbriones 1343384
feat: fix issue e2e for back button
lionellbriones 6d5cb67
Merge branch 'main' into feat/shield-plan-error-handling
lionellbriones 5071d81
feat: fixed e2e tests
lionellbriones e0248ca
feat: made error api component
lionellbriones 4e61710
feat: handle api errors on shield management page
lionellbriones 2b3d5fc
feat: removed back button e2e
lionellbriones 22d0d44
Merge branch 'main' into feat/shield-plan-error-handling
lionellbriones a3a625b
feat: fix lint
lionellbriones c1d4301
feat: handle onclose process before redirecting
lionellbriones f2e73c9
feat: fix check on homepage
lionellbriones b204457
feat: don't show api error behind loading
lionellbriones e38f99e
feat: add source from settings
lionellbriones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import React from 'react'; | ||
| import browser from 'webextension-polyfill'; | ||
| import { useI18nContext } from '../../../hooks/useI18nContext'; | ||
| import { | ||
| Box, | ||
| Button, | ||
| ButtonSize, | ||
| ButtonVariant, | ||
| Icon, | ||
| IconColor, | ||
| IconName, | ||
| Text, | ||
| TextVariant, | ||
| } from '@metamask/design-system-react'; | ||
| import classnames from 'classnames'; | ||
|
|
||
| const ApiErrorHandler = ({ className = '' }: { className?: string }) => { | ||
| const t = useI18nContext(); | ||
|
|
||
| return ( | ||
| <Box | ||
| className={classnames( | ||
| 'flex flex-col items-center text-center gap-4', | ||
| className, | ||
| )} | ||
| > | ||
| <Icon | ||
| className="w-12 h-12" | ||
| name={IconName.Error} | ||
| color={IconColor.IconAlternative} | ||
| /> | ||
| <Text variant={TextVariant.BodyMd}>{t('shieldPlanErrorText')}</Text> | ||
| <Button | ||
| className="w-full" | ||
| size={ButtonSize.Lg} | ||
| variant={ButtonVariant.Primary} | ||
| // this reloads the entire extension | ||
| onClick={() => browser.runtime.reload()} | ||
| > | ||
| {t('tryAgain')} | ||
| </Button> | ||
| </Box> | ||
| ); | ||
| }; | ||
|
|
||
| export default ApiErrorHandler; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { default } from './api-error-handler'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.