Skip to content

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 21, 2025

Description

fix: dapp-swap comparison fiat rate fetching for native tokens

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6327

Manual testing steps

  1. Trigger swap including native tokens
  2. Check that fait conversion in metrics is correct

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Fetch fiat rates only for non-native tokens in the dapp-swap comparison hook to correctly handle native assets.

  • Hooks:
    • Update ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapUSDValues.ts to filter out native addresses from tokenAddresses before calling fetchTokenExchangeRates('usd', ...), avoiding fiat rate requests for native tokens.

Written by Cursor Bugbot for commit 7ff0f9b. This will update automatically on new commits. Configure here.

@jpuri jpuri requested a review from a team as a code owner November 21, 2025 10:31
@jpuri jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Nov 21, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the base branch from release/13.10.0 to release/13.10.1 November 21, 2025 10:34
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 21, 2025

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (1 files, +6 -4)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 hooks/
          • 📁 transactions/
            • 📁 dapp-swap-comparison/
              • 📄 useDappSwapUSDValues.ts +6 -4

@jpuri jpuri closed this Nov 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
@jpuri jpuri reopened this Nov 21, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [7ff0f9b]
UI Startup Metrics (1241 ± 98 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1241107315369813151413
load107193213069111451245
domContentLoaded106392512999011371235
domInteractive231497191879
firstPaint71193130542910851229
backgroundConnect2362222749239255
firstReactRender2919144142947
getState20774102440
initialActions104112
loadScripts8346791074909061002
setupStore1062121115
numNetworkReqs1367619670
BrowserifyPower User HomeuiStartup19201529246227121882462
load1098920149620713921496
domContentLoaded1087913148720713831487
domInteractive581918659128186
firstPaint610122146744910011467
backgroundConnect2382292628240262
firstReactRender53436775867
getState20116032244222322
initialActions101011
loadScripts862687125920511521259
setupStore18134271942
numNetworkReqs936617241151172
WebpackStandard HomeuiStartup8547271199918631081
load62457096879625840
domContentLoaded61756395076617830
domInteractive191294151554
firstPaint19458916176201597
backgroundConnect261377142858
firstReactRender31196283740
getState1163741318
initialActions101011
loadScripts61456194073614819
setupStore1164041415
numNetworkReqs1367819872
WebpackPower User HomeuiStartup1102910189625412451896
load68757610821547801082
domContentLoaded67056510441387671044
domInteractive35131103787110
firstPaint27262786232393786
backgroundConnect50112396247239
firstReactRender41384624246
getState1459419526157195
initialActions101011
loadScripts66556310331357571033
setupStore962751027
numNetworkReqs73571322284132
FirefoxBrowserifyStandard HomeuiStartup14971343208713515121818
load1253115616739212621498
domContentLoaded1253115616729212621497
domInteractive56333644844172
firstPaint------
backgroundConnect4226163194565
firstReactRender28226252941
getState1176871222
initialActions213123
loadScripts1229113716468712381452
setupStore1477891432
numNetworkReqs1266415858
BrowserifyPower User HomeuiStartup27852354380141930213801
load14331259185318816341853
domContentLoaded14331259185218816341852
domInteractive18181447111301447
firstPaint------
backgroundConnect2827310973212561097
firstReactRender65528077080
getState21576582137211582
initialActions223033
loadScripts13881229182318415661823
setupStore18435568155351568
numNetworkReqs1156025070210250
WebpackStandard HomeuiStartup16541462218915017232004
load13891230168410714251633
domContentLoaded13891230168410714251633
domInteractive59302283471126
firstPaint------
backgroundConnect55271673063133
firstReactRender362785123782
getState207195341351
initialActions103123
loadScripts1352121216199814001584
setupStore15758121352
numNetworkReqs1366616762
WebpackPower User HomeuiStartup29882366408855736604088
load16011413205019117392050
domContentLoaded16011412205019117382050
domInteractive19459596164336596
firstPaint------
backgroundConnect27669923271461923
firstReactRender79548788587
getState16711724140209241
initialActions314134
loadScripts15661382201118617082011
setupStore13022768169117768
numNetworkReqs1155825970182259
📊 Page Load Benchmark Results

Current Commit: 7ff0f9b | Date: 11/21/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 733ms (±39ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±9ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 42ms 1.03s 1.36s 1.07s 1.36s
domContentLoaded 733ms 39ms 711ms 1.03s 751ms 1.03s
firstPaint 78ms 9ms 60ms 148ms 84ms 148ms
firstContentfulPaint 78ms 9ms 60ms 148ms 84ms 148ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

@gauthierpetetin gauthierpetetin merged commit eea4d3d into release/13.10.1 Nov 21, 2025
169 of 170 checks passed
@gauthierpetetin gauthierpetetin deleted the token_rate_fix branch November 21, 2025 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants