fix: removed isTestEnvironment check for rive animation
#38110
+77
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +0 -2)
🔐 @MetaMask/web3auth (9 files, +10 -24)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
smgv
changed the title
isTestEnvironment check for rive animation
Collaborator
Builds ready [a3fe5d9]
UI Startup Metrics (1220 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
lionellbriones
approved these changes
Nov 21, 2025
chaitanyapotti
approved these changes
Nov 21, 2025
Gudahtt
reviewed
Nov 21, 2025
| // In test environments or when returning from another page, skip animations | ||
| const [isAnimationComplete, setIsAnimationComplete] = useState( | ||
| isTestEnvironment || shouldSkipAnimation, | ||
| shouldSkipAnimation || false, |
Member
There was a problem hiding this comment.
Nit: Redundant extra condition:
Suggested change
| shouldSkipAnimation || false, | |
| shouldSkipAnimation, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we’ve removed the
isTestEnvironmentchecks from all Rive animation–related files. During the e2e tests, the animation component still callsuseRive, and since the WASM file isn’t set for the test environment, useRive falls back to fetching the WASM from external domains(unpkg.com and cdn.jsdelivr.net). This was causing unintended external calls during test execution. These changes address that issue.Jira Link: https://consensyssoftware.atlassian.net/browse/SL-334
Changelog
CHANGELOG entry: removed the
isTestEnvironmentchecks from all Rive animation–related filesRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes
IN_TESTgating from Rive animations, initializes WASM normally, and updates tests to mock animations with snapshot adjustments.isTestEnvironmentchecks to allow animations to render in all environments inwallet-ready-animation.tsx,fox-appear-animation.tsx,metamask-wordmark-animation.tsx,shield-icon-animation.tsx,shield-subscription-icon-animation.tsx,shield-illustration-animation.tsx, andcreation-successful.js.useRiveWasmReadyto always start withfalseand drop test-env shortcut; keep readiness whenRuntimeLoaderis undefined.welcome.jsandunlock-page.component.js.fox-appear-animation,metamask-wordmark-animation,wallet-ready-animation).Written by Cursor Bugbot for commit a3fe5d9. This will update automatically on new commits. Configure here.