feat: added pna-25 banner #38112
Draft
feat: added pna-25 banner #38112
+138
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| if (!onboardingDate || onboardingDate >= pna25Timestamp) { | ||
| return false; // User onboarded after PNA25 or no onboarding date | ||
| } |
There was a problem hiding this comment.
Bug: PNA25 banner excluded for users with no onboarding date
The condition prevents displaying the PNA25 banner to users with no onboardingDate (null), which is inconsistent with the docstring requirement "User onboarded before the PNA25 release date" and inconsistent with similar logic in selectShowPrivacyPolicyToast that explicitly includes such users. The comment suggests only blocking users who onboarded after PNA25, but the condition !onboardingDate || blocks null onboarding dates too.
|
|
||
| if (!onboardingDate || onboardingDate >= pna25Timestamp) { | ||
| return false; // User onboarded after PNA25 or no onboarding date | ||
| } |
There was a problem hiding this comment.
Bug: PNA25 banner excluded for users with no onboarding date
The condition prevents displaying the PNA25 banner to users with no onboardingDate (null), which is inconsistent with the docstring requirement "User onboarded before the PNA25 release date" and inconsistent with similar logic in selectShowPrivacyPolicyToast that explicitly includes such users. The condition !onboardingDate || blocks null onboarding dates when it should only block users who onboarded after the PNA25 timestamp.
Collaborator
Builds ready [3feccf9]
UI Startup Metrics (1168 ± 107 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the updated privacy notice banner
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces a LaunchDarkly-gated PNA25 MetaMetrics update banner with dismissal tracking, new app state fields/setters, selector logic, toast UI, and locale strings.
Pna25Bannertotoast-master.js; opensPRIVACY_POLICY_LINK, tracks dismiss viasetPna25BannerClickedOrClosedandsetPna25BannerDismissedDate.selectShowPna25BannerusingremoteFeatureFlags['extension-ux-pna25'],participateInMetaMetrics,onboardingDate, and dismissal state.pna25BannerClickedOrClosedandpna25BannerDismissedDatetoAppStateControllerstate, defaults, metadata, and setters.setPna25BannerClickedOrClosedandsetPna25BannerDismissedDate.pna25BannerTitleandpna25BannerActionButtonstrings inenanden_GB; normalize apostrophe innewPrivacyPolicyTitle.Written by Cursor Bugbot for commit 3feccf9. This will update automatically on new commits. Configure here.