-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: use maxConcurrency=1 for Snap account providers cp-13.11.0
#38116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ccharly
wants to merge
2
commits into
main
Choose a base branch
from
fix/reduce-account-snaps-max-concurrency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
maxConcurrency=1 for Snap account providers
app/scripts/controller-init/multichain/multichain-account-service-init.ts
Show resolved
Hide resolved
Collaborator
Builds ready [1b6f76a]
UI Startup Metrics (1245 ± 94 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [a5da3f4]
UI Startup Metrics (1207 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
maxConcurrency=1 for Snap account providersmaxConcurrency=1 for Snap account providers cp-13.11.0
aganglada
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that having concurrent calls to
keyring_createAccountcause some synchronization issues between Snap's accounts and MetaMask accounts. We're not sure of the real root cause yet for this, but preventing concurrent calls seems to mitigate (or even completely prevent) this kind of issues.Changelog
CHANGELOG entry: null
Related issues
Mitigates (partially): #37228
Manual testing steps
Nothing special to tests for this.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a shared Snap provider config with maxConcurrency=1, applies it to BTC/TRX providers, registers it for SOL, and updates tests accordingly.
app/scripts/controller-init/multichain/multichain-account-service-init.ts):snapAccountProviderConfigwithmaxConcurrency: 1and tuned timeouts.BtcAccountProviderandTrxAccountProviderviaAccountProviderWrapper.providerConfigs[{SOL_ACCOUNT_PROVIDER_NAME}]tosnapAccountProviderConfigwhen creatingMultichainAccountService.app/scripts/controller-init/multichain/multichain-account-service-init.test.ts):providerConfigsinMultichainAccountServiceconstructor args.Written by Cursor Bugbot for commit a5da3f4. This will update automatically on new commits. Configure here.