fix: feature flag sidepanel context menu cp-13.10.3 #38220
Merged
+76
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
n3ps
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
n3ps
changed the title
Collaborator
Builds ready [d5bdc68]
UI Startup Metrics (1195 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gauthierpetetin
changed the title
n3ps
force-pushed
the
n3ps/sidepanel-contextmenu
branch
from
97662ec to
04eb620
Compare
| } else { | ||
| removeMenu(); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Bug: Missing state comparison causes duplicate context menu operations
The RemoteFeatureFlagController:stateChange subscription doesn't compare previous and current values of extensionUxSidepanel. Unlike other parts of the codebase that use previousValueComparator, this code calls createMenu() or removeMenu() on every state change event without checking if the flag actually changed. If the menu already exists (created initially at line 33-35) and any state change occurs while still enabled, browser.contextMenus.create will fail with "Cannot create item with duplicate id" error. Similarly, calling removeMenu() when the menu doesn't exist will also fail.
Additional Locations (1)
NidhiKJha
previously approved these changes
Nov 25, 2025
Collaborator
Builds ready [04eb620]
UI Startup Metrics (1130 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| } else { | ||
| removeMenu(); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Bug: Context menu state changes cause duplicate creation errors
The state change subscription calls createMenu() or removeMenu() on every RemoteFeatureFlagController:stateChange event without tracking whether the menu already exists or comparing with the previous flag value. Since the state change event fires when ANY remote feature flag changes (not just extensionUxSidepanel), this will repeatedly try to create an already-existing menu item (causing "Cannot create item with duplicate id" error) or remove a non-existent menu. The codebase has an established previousValueComparator utility for this exact scenario that compares previous and current state before acting.
Additional Locations (1)
| if (info.menuItemId === MENU_ITEM_ID && tab?.windowId) { | ||
| browserWithSidePanel.sidePanel?.open({ windowId: tab.windowId }); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Bug: Context menu click handler only registered on install
The browser.contextMenus.onClicked listener is now registered inside initSidePanelContextMenu, which only runs when lazyListener.once('runtime', 'onInstalled') resolves. The onInstalled event only fires on fresh install, extension update, or browser update—not on regular browser restart or service worker wake-up. In the old code, the click listener was registered at module load time, ensuring it worked whenever the service worker started. Now, after a normal browser restart, the click handler won't be registered and clicking the context menu item will do nothing.
Additional Locations (1)
Collaborator
Builds ready [bc69ea7]
UI Startup Metrics (1257 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
NidhiKJha
approved these changes
Nov 25, 2025
NidhiKJha
reviewed
Nov 25, 2025
|
|
||
| const isEnabled = (state?: { | ||
| remoteFeatureFlags?: { extensionUxSidepanel?: boolean }; | ||
| }) => state?.remoteFeatureFlags?.extensionUxSidepanel !== false; |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| }) => state?.remoteFeatureFlags?.extensionUxSidepanel !== false; | |
| }) => state?.remoteFeatureFlags?.extensionUxSidepanel === true; |
AndyMBridges
approved these changes
Nov 25, 2025
metamaskbot
added
the
release-13.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #38222
Wraps the sidepanel context menu configuration with the remote feature flag
Changelog
CHANGELOG entry: fix: feature flag sidepanel context menu
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Gates the sidepanel context menu behind a remote feature flag and refactors its setup into a dedicated module initialized after background startup.
app/scripts/lib/sidepanel-context-menu.tswithinitSidePanelContextMenu(controller).openSidePanelmenu based onIS_SIDEPANELandremoteFeatureFlags.extensionUxSidepanel; opens side panel on click.RemoteFeatureFlagController:stateChangeto toggle menu dynamically.app/scripts/background.js, register sidepanel context menu vialazyListener.once('runtime','onInstalled'), callinghandleSidePanelContextMenu()afterhandleOnInstalled.handleSidePanelContextMenuwaits forisInitializedthen invokesinitSidePanelContextMenu(controller).Written by Cursor Bugbot for commit bc69ea7. This will update automatically on new commits. Configure here.