chore: Bump `eslint-plugin-react-hooks` from `^5.2.0` to `^7.0.1` #38376

MajorLift · 2025-11-28T02:06:31Z

Description

Replace deprecated pre-release react-compiler/react-compiler ruleset with react-hooks
Handle breaking changes from updating two major versions.
Use additionalEffectHooks config field to apply react-hooks/exhaustive-deps rule to custom hooks useAsync{Callback,Result,ResultOrThrow}

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-11-28T02:06:39Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-11-28T02:07:45Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	eslint-plugin-react-hooks@5.2.0 ⏵ 7.0.1				⁺²

View full report

MajorLift · 2025-11-28T02:08:37Z

@metamaskbot update-policies

metamaskbot · 2025-11-28T02:24:56Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-11-28T02:25:50Z

✨ Files requiring CODEOWNER review ✨

📜 @MetaMask/policy-reviewers (1 files, +57 -1)

📁 lavamoat/
- 📁 build-system/
  - 📄 policy.json +57 -1

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

metamaskbot · 2025-11-28T13:50:43Z

Builds ready [df0041f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 122 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1239	1041	1571	122	1330	1458
			load	1038	861	1299	105	1107	1243
			domContentLoaded	1032	858	1293	103	1101	1234
			domInteractive	26	16	96	20	22	82
			firstPaint	533	93	1269	402	1002	1171
			backgroundConnect	212	191	269	12	217	235
			firstReactRender	31	21	62	9	36	54
			getState	38	16	118	19	45	83
			initialActions	1	0	11	1	1	3
			loadScripts	826	660	1087	100	895	1024
			setupStore	12	5	43	6	13	25
			numNetworkReqs	12	5	78	20	5	73
	Browserify	Power User Home	uiStartup	2062	1750	2674	223	2167	2537
			load	1033	908	1417	110	1024	1318
			domContentLoaded	1018	901	1404	109	1015	1311
			domInteractive	36	19	132	25	35	116
			firstPaint	559	132	1421	387	976	1281
			backgroundConnect	260	201	761	106	234	554
			firstReactRender	60	42	107	13	66	84
			getState	189	132	727	60	204	230
			initialActions	1	0	4	1	1	2
			loadScripts	807	697	1192	108	802	1103
			setupStore	21	10	76	11	24	46
			numNetworkReqs	102	66	273	50	95	259
	Webpack	Standard Home	uiStartup	808	699	1161	79	826	976
			load	626	563	904	66	649	787
			domContentLoaded	621	560	896	66	644	778
			domInteractive	26	15	125	21	22	78
			firstPaint	272	79	784	191	319	657
			backgroundConnect	10	5	72	8	10	19
			firstReactRender	27	20	45	6	31	38
			getState	27	13	72	11	35	47
			initialActions	1	0	3	1	1	1
			loadScripts	619	557	886	64	642	769
			setupStore	10	6	20	3	12	16
			numNetworkReqs	12	5	77	20	5	73
	Webpack	Power User Home	uiStartup	1673	1367	2599	271	1957	2183
			load	693	592	1241	112	696	967
			domContentLoaded	683	584	1234	112	692	957
			domInteractive	38	17	196	34	33	135
			firstPaint	276	96	929	185	273	687
			backgroundConnect	47	8	579	116	18	488
			firstReactRender	63	44	101	10	69	82
			getState	183	130	731	59	189	227
			initialActions	1	0	4	1	1	2
			loadScripts	680	582	1225	110	690	948
			setupStore	22	10	70	12	24	48
			numNetworkReqs	168	67	427	84	219	415
Firefox	Browserify	Standard Home	uiStartup	1292	1040	1880	180	1405	1725
			load	1058	897	1377	110	1137	1276
			domContentLoaded	1057	896	1377	110	1137	1276
			domInteractive	55	31	131	29	69	114
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	21	256	41	42	149
			firstReactRender	25	18	54	8	25	45
			getState	12	7	89	11	10	20
			initialActions	1	0	3	1	1	2
			loadScripts	1027	881	1328	94	1097	1217
			setupStore	21	6	249	43	11	146
			numNetworkReqs	11	5	68	16	6	62
	Browserify	Power User Home	uiStartup	2624	2051	4846	464	2745	4016
			load	1195	970	2712	252	1181	1628
			domContentLoaded	1195	969	2711	252	1181	1628
			domInteractive	127	33	627	130	108	468
			firstPaint	-	-	-	-	-	-
			backgroundConnect	115	34	1527	158	110	314
			firstReactRender	61	38	276	27	61	99
			getState	284	87	908	232	365	825
			initialActions	4	0	43	8	2	34
			loadScripts	1150	947	2520	205	1151	1532
			setupStore	156	8	935	184	150	569
			numNetworkReqs	100	59	246	60	79	239
	Webpack	Standard Home	uiStartup	1479	1265	1862	143	1564	1792
			load	1225	1065	1604	111	1302	1414
			domContentLoaded	1225	1065	1603	111	1301	1414
			domInteractive	55	27	139	31	76	117
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	17	154	25	45	107
			firstReactRender	27	20	83	9	27	37
			getState	14	6	151	17	13	40
			initialActions	1	0	2	0	2	2
			loadScripts	1196	1049	1538	102	1274	1388
			setupStore	17	5	256	30	14	45
			numNetworkReqs	12	5	73	17	7	63
	Webpack	Power User Home	uiStartup	3172	2157	5756	843	3408	5004
			load	1612	1203	3415	519	1708	3018
			domContentLoaded	1611	1203	3415	519	1708	3018
			domInteractive	135	31	1124	162	111	499
			firstPaint	-	-	-	-	-	-
			backgroundConnect	175	23	1210	216	163	426
			firstReactRender	70	44	232	31	70	152
			getState	262	70	1113	218	322	806
			initialActions	4	0	94	11	2	6
			loadScripts	1541	1176	3228	443	1677	2829
			setupStore	140	10	1133	186	154	606
			numNetworkReqs	101	62	251	61	79	243

📊 Page Load Benchmark Results

Current Commit: df0041f | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±56ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 722ms (±53ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	56ms	1.01s	1.33s	1.07s	1.33s
domContentLoaded	722ms	53ms	699ms	1.02s	752ms	1.02s
firstPaint	76ms	10ms	60ms	160ms	88ms	160ms
firstContentfulPaint	76ms	10ms	60ms	160ms	88ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.21 KiB (0.03%)
ui: 11.61 KiB (0.15%)
common: 9.58 KiB (0.11%)

…mended`

MajorLift · 2025-11-28T21:43:22Z

@metamaskbot update-policies

metamaskbot · 2025-11-28T21:59:17Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-11-28T22:31:54Z

Builds ready [c5d7a56]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1235 ± 107 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1235	1016	1560	107	1295	1478
			load	1035	861	1360	99	1091	1219
			domContentLoaded	1028	856	1353	97	1085	1198
			domInteractive	28	16	184	27	21	81
			firstPaint	529	89	1300	417	991	1173
			backgroundConnect	215	197	263	14	223	245
			firstReactRender	30	19	82	11	34	56
			getState	38	15	138	19	44	66
			initialActions	1	0	6	1	1	3
			loadScripts	820	652	1097	94	875	983
			setupStore	13	6	32	5	13	24
			numNetworkReqs	12	5	78	21	5	75
	Browserify	Power User Home	uiStartup	2033	1681	3144	265	2114	2548
			load	1010	882	1782	138	1000	1359
			domContentLoaded	995	876	1736	137	978	1336
			domInteractive	35	18	150	29	34	130
			firstPaint	553	116	1787	393	971	1296
			backgroundConnect	270	197	729	126	232	599
			firstReactRender	57	41	104	14	61	93
			getState	179	141	248	23	197	227
			initialActions	1	0	4	1	1	3
			loadScripts	790	685	1524	137	775	1130
			setupStore	20	10	43	7	23	39
			numNetworkReqs	155	66	408	77	206	320
	Webpack	Standard Home	uiStartup	819	693	1096	88	848	1019
			load	639	566	878	81	669	820
			domContentLoaded	635	561	869	80	665	815
			domInteractive	26	14	109	21	22	90
			firstPaint	219	78	874	154	204	583
			backgroundConnect	11	4	45	8	14	27
			firstReactRender	29	20	239	22	31	38
			getState	26	14	68	11	33	45
			initialActions	1	0	6	1	1	1
			loadScripts	632	558	860	78	663	805
			setupStore	10	6	21	3	12	17
			numNetworkReqs	12	5	76	20	5	74
	Webpack	Power User Home	uiStartup	1645	1257	2530	280	1913	2151
			load	679	581	1359	115	680	944
			domContentLoaded	669	576	1349	115	666	938
			domInteractive	37	17	245	36	30	127
			firstPaint	284	96	960	213	263	903
			backgroundConnect	70	7	663	161	19	555
			firstReactRender	60	42	89	8	65	77
			getState	182	143	656	69	183	212
			initialActions	1	0	3	1	1	2
			loadScripts	667	574	1340	113	664	929
			setupStore	21	8	58	12	24	46
			numNetworkReqs	170	66	424	83	220	408
Firefox	Browserify	Standard Home	uiStartup	1283	1079	1727	147	1363	1615
			load	1069	912	1424	100	1126	1275
			domContentLoaded	1068	911	1423	100	1126	1275
			domInteractive	54	31	152	29	82	118
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	21	165	23	46	93
			firstReactRender	22	18	41	4	23	35
			getState	13	7	148	19	10	23
			initialActions	1	0	2	0	1	2
			loadScripts	1042	897	1344	92	1097	1250
			setupStore	13	6	143	15	11	34
			numNetworkReqs	11	5	66	16	7	63
	Browserify	Power User Home	uiStartup	2551	1909	4118	481	2702	3801
			load	1140	935	2371	192	1148	1486
			domContentLoaded	1139	929	2370	192	1148	1485
			domInteractive	115	34	465	99	110	402
			firstPaint	-	-	-	-	-	-
			backgroundConnect	95	24	405	69	107	248
			firstReactRender	58	38	144	16	60	90
			getState	241	68	958	188	244	682
			initialActions	2	0	28	3	2	3
			loadScripts	1109	916	2232	177	1114	1416
			setupStore	159	7	789	194	197	649
			numNetworkReqs	99	61	256	58	79	234
	Webpack	Standard Home	uiStartup	1482	1280	2191	158	1554	1755
			load	1228	1077	1580	103	1281	1423
			domContentLoaded	1228	1076	1580	103	1280	1423
			domInteractive	63	27	229	38	81	139
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	21	248	36	49	126
			firstReactRender	26	20	68	6	28	38
			getState	12	7	62	9	12	22
			initialActions	1	0	2	1	2	2
			loadScripts	1203	1050	1550	98	1259	1373
			setupStore	12	5	54	9	14	35
			numNetworkReqs	11	5	65	15	7	54
	Webpack	Power User Home	uiStartup	2875	2087	5450	669	2921	4520
			load	1469	1184	2772	398	1486	2503
			domContentLoaded	1468	1184	2772	398	1486	2503
			domInteractive	101	30	473	86	90	355
			firstPaint	-	-	-	-	-	-
			backgroundConnect	128	29	932	146	137	237
			firstReactRender	64	41	182	22	65	112
			getState	270	57	1051	235	359	835
			initialActions	2	1	25	2	2	3
			loadScripts	1413	1151	2726	354	1457	2371
			setupStore	105	9	676	132	105	396
			numNetworkReqs	102	61	252	61	79	242

📊 Page Load Benchmark Results

Current Commit: c5d7a56 | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±53ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 731ms (±50ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	53ms	1.02s	1.34s	1.09s	1.34s
domContentLoaded	731ms	50ms	702ms	1.00s	757ms	1.00s
firstPaint	77ms	11ms	60ms	168ms	88ms	168ms
firstContentfulPaint	77ms	11ms	60ms	168ms	88ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

MajorLift · 2025-12-02T06:43:03Z

@metamaskbot update-policies

metamaskbot · 2025-12-02T07:00:26Z

No policy changes

metamaskbot · 2025-12-02T16:44:40Z

Builds ready [4218002]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 100 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1239	1037	1641	100	1287	1400
			load	1041	858	1435	95	1087	1203
			domContentLoaded	1035	853	1429	94	1077	1190
			domInteractive	25	15	99	18	21	76
			firstPaint	514	92	1285	409	1037	1196
			backgroundConnect	218	196	251	11	224	239
			firstReactRender	28	20	57	8	30	48
			getState	35	16	132	20	40	78
			initialActions	1	0	4	1	1	2
			loadScripts	824	649	1214	93	862	986
			setupStore	12	6	32	5	12	25
			numNetworkReqs	12	5	74	20	5	72
	Browserify	Power User Home	uiStartup	2018	1728	2554	187	2141	2379
			load	1015	897	1524	126	1005	1352
			domContentLoaded	1001	889	1515	127	990	1341
			domInteractive	35	18	126	26	36	119
			firstPaint	501	93	1527	385	955	1239
			backgroundConnect	256	204	635	99	234	567
			firstReactRender	53	37	109	12	57	89
			getState	185	134	295	30	203	245
			initialActions	1	0	3	1	1	2
			loadScripts	791	667	1294	125	782	1130
			setupStore	20	10	56	9	22	40
			numNetworkReqs	158	69	290	57	210	270
	Webpack	Standard Home	uiStartup	850	728	1159	88	880	1030
			load	657	580	936	76	677	852
			domContentLoaded	652	572	927	75	673	844
			domInteractive	29	16	167	26	25	103
			firstPaint	227	86	896	160	210	658
			backgroundConnect	10	6	28	4	10	17
			firstReactRender	29	20	97	10	35	43
			getState	29	14	80	14	37	57
			initialActions	1	0	3	1	1	2
			loadScripts	649	570	917	73	670	835
			setupStore	11	5	27	4	14	19
			numNetworkReqs	12	5	77	20	5	71
	Webpack	Power User Home	uiStartup	1644	1294	2448	226	1800	2059
			load	686	591	1008	89	690	918
			domContentLoaded	675	584	1002	90	678	912
			domInteractive	37	20	169	31	34	113
			firstPaint	276	88	917	193	256	708
			backgroundConnect	73	8	680	160	21	580
			firstReactRender	62	46	97	9	66	78
			getState	190	128	729	93	189	222
			initialActions	1	0	4	1	1	2
			loadScripts	672	582	993	88	676	903
			setupStore	21	10	56	12	24	48
			numNetworkReqs	144	69	297	57	203	239
Firefox	Browserify	Standard Home	uiStartup	1309	1110	1862	134	1385	1563
			load	1077	946	1318	80	1129	1222
			domContentLoaded	1077	941	1317	80	1125	1222
			domInteractive	60	31	175	32	85	125
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	21	205	36	48	138
			firstReactRender	23	17	54	6	24	36
			getState	12	5	127	14	10	24
			initialActions	1	0	33	3	1	2
			loadScripts	1052	925	1291	75	1095	1192
			setupStore	13	5	139	15	13	37
			numNetworkReqs	12	5	65	16	7	60
	Browserify	Power User Home	uiStartup	2677	1958	5117	527	2738	4189
			load	1239	979	2986	311	1255	1630
			domContentLoaded	1239	979	2985	311	1255	1630
			domInteractive	129	34	589	106	128	384
			firstPaint	-	-	-	-	-	-
			backgroundConnect	160	26	1136	197	139	711
			firstReactRender	58	39	108	15	63	99
			getState	287	56	937	220	337	776
			initialActions	2	1	39	4	2	7
			loadScripts	1202	964	2792	277	1218	1607
			setupStore	126	5	742	158	135	604
			numNetworkReqs	93	60	331	45	95	214
	Webpack	Standard Home	uiStartup	1555	1330	2039	158	1638	1945
			load	1282	1113	1590	103	1355	1464
			domContentLoaded	1282	1112	1590	103	1354	1464
			domInteractive	67	28	166	36	87	133
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	19	130	28	50	112
			firstReactRender	25	19	84	7	26	37
			getState	19	7	203	29	14	82
			initialActions	2	0	5	1	3	4
			loadScripts	1255	1096	1573	97	1330	1428
			setupStore	15	6	86	16	13	65
			numNetworkReqs	12	5	66	17	7	62
	Webpack	Power User Home	uiStartup	3182	2399	6411	633	3275	4749
			load	1654	1313	3019	395	1848	2870
			domContentLoaded	1654	1313	3019	395	1847	2870
			domInteractive	150	34	953	147	137	510
			firstPaint	-	-	-	-	-	-
			backgroundConnect	202	32	1231	201	196	635
			firstReactRender	72	46	240	28	72	112
			getState	255	78	873	195	259	708
			initialActions	3	1	16	2	3	8
			loadScripts	1586	1293	2851	325	1740	2286
			setupStore	174	12	1053	224	139	691
			numNetworkReqs	93	63	302	49	82	221

📊 Page Load Benchmark Results

Current Commit: 4218002 | Date: 12/2/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±64ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 734ms (±79ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 80ms (±44ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	64ms	1.01s	1.35s	1.25s	1.35s
domContentLoaded	734ms	79ms	702ms	1.31s	932ms	1.31s
firstPaint	80ms	44ms	56ms	508ms	88ms	508ms
firstContentfulPaint	80ms	44ms	56ms	508ms	88ms	508ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 503.75 KiB (10.77%)
ui: -1.33 KiB (-0.02%)
common: 188.08 KiB (2.13%)

metamaskbot · 2025-12-02T18:40:43Z

Builds ready [b5bf4b8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1289 ± 112 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1289	1061	1650	112	1354	1493
			load	1077	899	1448	106	1144	1274
			domContentLoaded	1070	891	1439	105	1137	1266
			domInteractive	31	15	174	31	23	89
			firstPaint	571	95	1303	417	1066	1236
			backgroundConnect	228	198	283	16	236	262
			firstReactRender	31	19	58	9	35	51
			getState	37	16	128	15	45	61
			initialActions	1	0	5	1	1	2
			loadScripts	849	667	1228	106	908	1046
			setupStore	13	7	36	5	14	23
			numNetworkReqs	12	5	77	20	5	73
	Browserify	Power User Home	uiStartup	1998	1702	2892	173	2070	2366
			load	1043	922	1739	132	1054	1309
			domContentLoaded	1028	906	1727	133	1041	1301
			domInteractive	34	18	148	23	34	99
			firstPaint	502	89	1754	392	972	1269
			backgroundConnect	247	206	557	74	238	495
			firstReactRender	56	40	112	14	58	95
			getState	185	134	273	29	203	242
			initialActions	1	0	6	1	1	3
			loadScripts	814	702	1470	130	825	1092
			setupStore	19	10	42	7	22	35
			numNetworkReqs	94	68	223	25	101	153
	Webpack	Standard Home	uiStartup	839	705	1204	91	866	1034
			load	644	575	1002	78	659	811
			domContentLoaded	640	568	989	77	654	807
			domInteractive	27	16	117	23	23	93
			firstPaint	217	88	794	143	202	624
			backgroundConnect	12	6	71	12	11	46
			firstReactRender	30	20	123	14	33	39
			getState	27	13	63	11	35	47
			initialActions	1	0	4	1	1	1
			loadScripts	637	566	984	75	652	798
			setupStore	11	6	24	4	14	18
			numNetworkReqs	12	5	73	20	5	71
	Webpack	Power User Home	uiStartup	1572	1256	2157	223	1665	2033
			load	670	588	1111	87	680	875
			domContentLoaded	659	574	1104	88	671	871
			domInteractive	35	17	165	30	31	121
			firstPaint	267	87	878	189	259	685
			backgroundConnect	37	7	617	96	19	95
			firstReactRender	58	42	114	10	61	82
			getState	188	130	716	89	182	227
			initialActions	1	0	3	1	1	2
			loadScripts	656	572	1092	86	669	861
			setupStore	20	6	58	10	23	46
			numNetworkReqs	162	68	399	65	218	296
Firefox	Browserify	Standard Home	uiStartup	1268	1085	1714	133	1345	1534
			load	1055	925	1391	91	1111	1224
			domContentLoaded	1054	924	1391	91	1111	1223
			domInteractive	56	31	171	32	81	130
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	21	253	39	42	122
			firstReactRender	21	18	35	4	22	33
			getState	12	6	190	20	9	22
			initialActions	1	0	2	0	1	2
			loadScripts	1027	910	1313	80	1062	1187
			setupStore	13	5	95	14	10	37
			numNetworkReqs	11	5	68	15	6	57
	Browserify	Power User Home	uiStartup	2656	2159	5236	512	2729	3704
			load	1211	970	3003	300	1243	1527
			domContentLoaded	1211	970	3003	300	1243	1527
			domInteractive	116	33	435	85	117	344
			firstPaint	-	-	-	-	-	-
			backgroundConnect	163	27	1159	225	138	681
			firstReactRender	58	36	136	16	61	93
			getState	285	57	905	209	384	795
			initialActions	2	0	51	6	2	3
			loadScripts	1154	933	2812	216	1204	1498
			setupStore	125	4	925	172	137	617
			numNetworkReqs	94	58	239	37	107	172
	Webpack	Standard Home	uiStartup	1531	1285	1901	155	1647	1839
			load	1261	1118	1516	105	1329	1479
			domContentLoaded	1260	1118	1516	105	1329	1477
			domInteractive	67	30	183	34	83	132
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	19	181	29	54	123
			firstReactRender	26	19	63	7	29	36
			getState	15	7	154	20	13	35
			initialActions	2	0	5	1	3	5
			loadScripts	1234	1103	1463	96	1297	1424
			setupStore	19	7	214	27	17	69
			numNetworkReqs	12	5	69	18	7	67
	Webpack	Power User Home	uiStartup	2967	2088	5366	746	2970	4690
			load	1502	1173	2880	414	1573	2668
			domContentLoaded	1502	1172	2880	414	1573	2667
			domInteractive	111	32	731	104	102	363
			firstPaint	-	-	-	-	-	-
			backgroundConnect	145	33	1051	162	149	470
			firstReactRender	61	40	188	23	63	99
			getState	314	65	1864	286	442	859
			initialActions	2	0	8	1	2	3
			loadScripts	1440	1143	2592	349	1511	2421
			setupStore	142	6	811	198	132	663
			numNetworkReqs	91	59	219	34	103	170

📊 Page Load Benchmark Results

Current Commit: b5bf4b8 | Date: 12/2/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±62ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 723ms (±60ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	62ms	1.00s	1.32s	1.24s	1.32s
domContentLoaded	723ms	60ms	696ms	990ms	921ms	990ms
firstPaint	76ms	13ms	60ms	192ms	84ms	192ms
firstContentfulPaint	76ms	13ms	60ms	192ms	84ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 503.93 KiB (10.78%)
ui: -1.07 KiB (-0.01%)
common: 188.26 KiB (2.13%)

metamaskbot · 2025-12-02T20:02:23Z

Builds ready [bf20571]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1252 ± 102 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1252	1035	1496	102	1330	1425
			load	1046	873	1272	88	1101	1191
			domContentLoaded	1039	867	1255	88	1096	1182
			domInteractive	26	15	91	18	23	80
			firstPaint	541	92	1268	405	1016	1188
			backgroundConnect	220	201	265	13	228	243
			firstReactRender	29	20	62	8	31	50
			getState	36	14	93	14	44	59
			initialActions	1	0	5	1	1	2
			loadScripts	826	666	1011	84	872	974
			setupStore	11	5	23	3	12	19
			numNetworkReqs	12	5	76	20	5	72
	Browserify	Power User Home	uiStartup	2053	1755	2770	203	2107	2468
			load	1016	883	1511	116	1013	1315
			domContentLoaded	1001	879	1501	117	992	1305
			domInteractive	33	18	105	20	33	93
			firstPaint	492	106	1523	372	946	1253
			backgroundConnect	253	203	774	105	232	536
			firstReactRender	58	39	124	15	62	94
			getState	202	137	711	77	212	254
			initialActions	1	0	11	2	1	4
			loadScripts	792	680	1274	113	785	1081
			setupStore	21	9	74	10	24	39
			numNetworkReqs	151	68	288	53	202	257
	Webpack	Standard Home	uiStartup	840	705	1069	85	874	1030
			load	658	571	861	78	698	822
			domContentLoaded	653	562	855	77	688	816
			domInteractive	28	15	117	23	23	97
			firstPaint	211	95	733	129	198	613
			backgroundConnect	10	5	30	6	13	27
			firstReactRender	27	20	48	6	31	39
			getState	25	14	59	11	35	45
			initialActions	1	0	5	1	1	1
			loadScripts	650	559	853	76	685	807
			setupStore	10	6	21	3	11	16
			numNetworkReqs	12	5	72	20	5	71
	Webpack	Power User Home	uiStartup	1876	1525	3187	288	2116	2345
			load	754	638	1207	108	770	1016
			domContentLoaded	742	630	1190	108	754	1008
			domInteractive	42	20	178	33	39	138
			firstPaint	305	112	996	185	308	738
			backgroundConnect	111	8	752	215	25	674
			firstReactRender	66	49	122	11	72	82
			getState	226	147	902	124	216	337
			initialActions	1	0	4	1	1	3
			loadScripts	739	628	1187	106	752	997
			setupStore	25	7	64	14	28	54
			numNetworkReqs	164	69	297	61	222	275
Firefox	Browserify	Standard Home	uiStartup	1257	1055	1692	145	1354	1589
			load	1045	895	1395	94	1109	1262
			domContentLoaded	1044	894	1395	94	1109	1262
			domInteractive	54	29	135	28	82	111
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	21	204	31	46	103
			firstReactRender	21	17	38	4	21	34
			getState	12	7	138	15	10	19
			initialActions	1	0	2	0	1	2
			loadScripts	1019	879	1271	84	1072	1227
			setupStore	14	5	215	27	9	41
			numNetworkReqs	12	5	68	16	6	63
	Browserify	Power User Home	uiStartup	2679	1981	4579	523	2715	4287
			load	1282	1016	2615	344	1242	2469
			domContentLoaded	1281	1016	2615	344	1241	2469
			domInteractive	126	35	528	101	129	407
			firstPaint	-	-	-	-	-	-
			backgroundConnect	142	29	1024	143	160	459
			firstReactRender	57	38	109	14	59	98
			getState	256	84	1006	204	278	788
			initialActions	2	0	7	1	2	3
			loadScripts	1240	991	2481	317	1210	2333
			setupStore	160	6	805	193	168	654
			numNetworkReqs	92	63	222	37	102	191
	Webpack	Standard Home	uiStartup	1532	1247	2206	151	1603	1771
			load	1265	1089	1636	103	1309	1492
			domContentLoaded	1265	1089	1636	103	1309	1492
			domInteractive	63	29	249	36	82	131
			firstPaint	-	-	-	-	-	-
			backgroundConnect	53	21	163	31	68	115
			firstReactRender	26	19	76	9	28	37
			getState	14	6	121	15	13	44
			initialActions	2	0	41	4	3	4
			loadScripts	1232	1071	1560	95	1278	1425
			setupStore	16	5	233	27	14	41
			numNetworkReqs	12	5	68	17	7	63
	Webpack	Power User Home	uiStartup	3007	2070	5381	800	3227	4748
			load	1470	1111	2832	374	1570	2668
			domContentLoaded	1469	1111	2831	374	1569	2668
			domInteractive	123	29	922	130	113	387
			firstPaint	-	-	-	-	-	-
			backgroundConnect	156	27	1215	213	128	620
			firstReactRender	67	38	258	40	64	175
			getState	305	61	1410	271	421	852
			initialActions	2	0	30	3	2	3
			loadScripts	1413	1094	2651	300	1509	2065
			setupStore	139	7	1060	199	125	651
			numNetworkReqs	93	61	314	41	112	170

📊 Page Load Benchmark Results

Current Commit: bf20571 | Date: 12/2/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 710ms (±37ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	41ms	998ms	1.31s	1.05s	1.31s
domContentLoaded	710ms	37ms	690ms	984ms	731ms	984ms
firstPaint	74ms	11ms	56ms	156ms	84ms	156ms
firstContentfulPaint	74ms	11ms	56ms	156ms	84ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 503.93 KiB (10.78%)
ui: -1.08 KiB (-0.01%)
common: 188.26 KiB (2.13%)

metamaskbot added the team-extension-platform Extension Platform team label Nov 28, 2025

github-actions bot added the size-XS label Nov 28, 2025

github-actions bot added size-S and removed size-XS labels Nov 28, 2025

MajorLift force-pushed the jongsun/chore/lint/bump-eslint-plugin-react-hooks-to-v7 branch from 1c090f1 to df0041f Compare November 28, 2025 13:10

MajorLift and others added 4 commits November 28, 2025 16:42

Bump eslint-plugin-react-hooks from ^5.2.0 to ^6.1.1

dc993b9

Update LavaMoat policies

c36fe5f

Manually configure lint entries provided by `plugin:react-hooks/recom…

07de5fa

…mended`

Bump eslint-plugin-react-hooks from ^6.1.1 to ^7.0.1

402c831

MajorLift force-pushed the jongsun/chore/lint/bump-eslint-plugin-react-hooks-to-v7 branch from df0041f to 402c831 Compare November 28, 2025 21:43

Update LavaMoat policies

c5d7a56

Remove deprecated eslint-plugin-react-compiler pre-release version

193326d

Replace react-compiler ESLint rules with react-hooks rules

ccf0c2d

MajorLift force-pushed the jongsun/chore/lint/bump-eslint-plugin-react-hooks-to-v7 branch from 4218002 to b5bf4b8 Compare December 2, 2025 18:03

Set most new rulesets to warn

bf20571

MajorLift force-pushed the jongsun/chore/lint/bump-eslint-plugin-react-hooks-to-v7 branch from b5bf4b8 to bf20571 Compare December 2, 2025 19:29

chore: Bump eslint-plugin-react-hooks from ^5.2.0 to ^7.0.1 #38376

Are you sure you want to change the base?

chore: Bump eslint-plugin-react-hooks from ^5.2.0 to ^7.0.1 #38376

Conversation

MajorLift commented Nov 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

socket-security bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MajorLift commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

MajorLift commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

MajorLift commented Dec 2, 2025

Uh oh!

metamaskbot commented Dec 2, 2025

Uh oh!

metamaskbot commented Dec 2, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 2, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 2, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: Bump `eslint-plugin-react-hooks` from `^5.2.0` to `^7.0.1` #38376

chore: Bump `eslint-plugin-react-hooks` from `^5.2.0` to `^7.0.1` #38376

MajorLift commented Nov 28, 2025 •

edited by github-actions bot

Loading

socket-security bot commented Nov 28, 2025 •

edited

Loading

metamaskbot commented Nov 28, 2025 •

edited

Loading