fix: when Network manager selection is Solana and a new popular network is added, the defi and NFTs tabs are missing #38419

salimtb · 2025-12-01T01:14:58Z

Description

when Network manager selection is Solana and a new popular network is added, the defi and NFTs tabs are missing

Changelog

CHANGELOG entry: when Network manager selection is Solana and a new popular network is added, the defi and NFTs tabs are missing

Related issues

Fixes: #36845

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-12-01.at.12.49.02.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Non‑EVM account overview now shows NFTs and DeFi tabs only when any EVM network is enabled (and DeFi flag), powered by a new selector and comprehensive tests.

UI (Account Overview):
- AccountOverviewNonEvm uses getHasAnyEvmNetworkEnabled and getIsDefiPositionsEnabled to set showNfts and showDefi in AccountOverviewLayout.
Selectors:
- Add getHasAnyEvmNetworkEnabled to detect if any EVM network is enabled via enabledNetworkMap.
Tests:
- Expand account-overview-non-evm.test.tsx to cover cases with no EVM networks, with EVM networks (DeFi on/off), single EVM network, and switching to non‑EVM (Solana).
- Add unit tests for getHasAnyEvmNetworkEnabled in selectors.test.js.

^{Written by Cursor Bugbot for commit f468f23. This will update automatically on new commits. Configure here.}

…rk is added, the DeFi and NFTs tabs are missing

github-actions · 2025-12-01T01:15:07Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-12-01T01:15:39Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +138 -16)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-overview/
      - 📄 account-overview-non-evm.test.tsx +128 -15
      - 📄 account-overview-non-evm.tsx +10 -1

👨‍🔧 @MetaMask/core-extension-ux (2 files, +138 -16)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-overview/
      - 📄 account-overview-non-evm.test.tsx +128 -15
      - 📄 account-overview-non-evm.tsx +10 -1

metamaskbot · 2025-12-01T01:48:31Z

Builds ready [1ad6e12]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1211 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1211	1007	1418	96	1285	1364
			load	1013	861	1242	88	1059	1182
			domContentLoaded	1007	857	1234	87	1056	1175
			domInteractive	25	14	133	21	21	88
			firstPaint	556	96	1194	403	1012	1144
			backgroundConnect	210	193	244	11	216	234
			firstReactRender	29	19	55	8	34	50
			getState	34	16	122	17	39	57
			initialActions	1	0	5	1	1	2
			loadScripts	802	658	1032	84	843	955
			setupStore	11	6	53	6	13	19
			numNetworkReqs	12	5	78	20	5	73
	Browserify	Power User Home	uiStartup	2011	1637	3384	275	2086	2604
			load	979	851	1772	154	985	1343
			domContentLoaded	963	844	1762	153	963	1325
			domInteractive	32	17	134	24	30	91
			firstPaint	635	112	1443	368	921	1166
			backgroundConnect	249	187	722	117	222	526
			firstReactRender	61	38	115	16	64	100
			getState	184	146	309	29	202	233
			initialActions	1	0	8	1	1	3
			loadScripts	775	659	1530	148	769	1132
			setupStore	19	9	63	9	22	39
			numNetworkReqs	103	65	295	57	95	279
	Webpack	Standard Home	uiStartup	843	716	1079	80	880	1013
			load	654	578	878	78	674	841
			domContentLoaded	649	571	871	77	671	835
			domInteractive	28	15	128	24	22	95
			firstPaint	239	107	877	177	212	664
			backgroundConnect	11	6	83	10	10	17
			firstReactRender	29	20	72	9	33	42
			getState	27	12	58	11	35	49
			initialActions	1	0	5	1	1	2
			loadScripts	646	566	862	75	669	824
			setupStore	11	6	38	5	13	22
			numNetworkReqs	12	5	77	20	5	73
	Webpack	Power User Home	uiStartup	1590	1256	2331	259	1724	2111
			load	678	578	1080	101	675	933
			domContentLoaded	668	572	1072	101	660	928
			domInteractive	35	18	148	28	31	112
			firstPaint	303	88	1079	218	305	834
			backgroundConnect	36	7	595	93	17	283
			firstReactRender	59	45	77	7	64	71
			getState	177	140	233	18	186	220
			initialActions	1	0	4	1	1	2
			loadScripts	665	570	1062	100	658	920
			setupStore	20	9	59	12	23	49
			numNetworkReqs	171	67	430	83	220	397
Firefox	Browserify	Standard Home	uiStartup	1249	1085	1649	119	1330	1455
			load	1045	927	1314	82	1099	1202
			domContentLoaded	1044	927	1314	81	1099	1202
			domInteractive	56	30	201	32	80	133
			firstPaint	-	-	-	-	-	-
			backgroundConnect	38	18	156	24	38	89
			firstReactRender	22	18	53	5	23	36
			getState	13	6	205	23	9	22
			initialActions	1	0	2	0	1	2
			loadScripts	1020	910	1284	75	1065	1158
			setupStore	12	5	155	18	10	27
			numNetworkReqs	11	5	65	16	6	60
	Browserify	Power User Home	uiStartup	2646	1920	4581	551	2734	4115
			load	1178	930	2729	258	1165	1558
			domContentLoaded	1178	930	2729	258	1165	1558
			domInteractive	107	32	548	90	108	336
			firstPaint	-	-	-	-	-	-
			backgroundConnect	118	26	1014	141	113	266
			firstReactRender	62	38	223	23	63	109
			getState	279	64	1012	210	360	747
			initialActions	3	0	102	10	2	4
			loadScripts	1146	910	2567	239	1133	1522
			setupStore	182	6	798	215	231	692
			numNetworkReqs	100	61	249	58	79	235
	Webpack	Standard Home	uiStartup	1494	1263	2070	153	1583	1817
			load	1241	1080	1518	103	1305	1447
			domContentLoaded	1240	1080	1518	103	1304	1447
			domInteractive	52	25	147	31	77	108
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	20	191	33	44	122
			firstReactRender	24	20	40	4	25	31
			getState	13	7	124	13	13	27
			initialActions	1	0	2	0	1	2
			loadScripts	1212	1050	1444	92	1280	1367
			setupStore	14	6	192	21	13	37
			numNetworkReqs	12	5	69	18	7	67
	Webpack	Power User Home	uiStartup	2961	2055	5483	759	3077	4690
			load	1468	1143	3027	415	1498	2739
			domContentLoaded	1468	1142	3026	415	1498	2738
			domInteractive	105	27	637	103	101	344
			firstPaint	-	-	-	-	-	-
			backgroundConnect	160	35	1220	214	150	500
			firstReactRender	64	38	185	23	63	110
			getState	294	73	1243	239	362	757
			initialActions	2	1	37	4	2	3
			loadScripts	1401	1117	2872	352	1456	2448
			setupStore	155	6	846	198	175	724
			numNetworkReqs	101	57	249	55	112	243

📊 Page Load Benchmark Results

Current Commit: 1ad6e12 | Date: 12/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±39ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±15ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	41ms	1.01s	1.34s	1.07s	1.34s
domContentLoaded	720ms	39ms	697ms	1.01s	745ms	1.01s
firstPaint	77ms	15ms	56ms	216ms	84ms	216ms
firstContentfulPaint	77ms	15ms	56ms	216ms	84ms	216ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 896 Bytes (0.02%)
ui: 3.23 KiB (0.04%)
common: 1.15 KiB (0.01%)

…on-is-solana-and-a-new-popular-network-is-added-the-de-fi-and-nf-ts-tabs-are-missing

metamaskbot · 2025-12-01T12:23:18Z

Builds ready [f468f23]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1181 ± 112 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1181	992	1582	112	1244	1392
			load	984	820	1285	95	1027	1159
			domContentLoaded	977	816	1279	94	1023	1153
			domInteractive	23	14	100	18	19	74
			firstPaint	489	75	1160	373	952	1086
			backgroundConnect	195	176	232	11	201	221
			firstReactRender	31	18	62	9	37	48
			getState	37	14	161	23	43	96
			initialActions	1	0	6	1	1	2
			loadScripts	789	636	1087	91	830	970
			setupStore	12	6	39	6	14	27
			numNetworkReqs	12	5	77	21	5	77
	Browserify	Power User Home	uiStartup	2043	1672	2773	239	2082	2613
			load	1033	904	1524	133	1051	1377
			domContentLoaded	1018	893	1514	135	1031	1373
			domInteractive	35	18	152	26	33	112
			firstPaint	550	104	1528	404	971	1338
			backgroundConnect	259	200	753	108	231	522
			firstReactRender	58	42	119	13	61	93
			getState	188	138	644	52	199	230
			initialActions	1	0	4	1	1	2
			loadScripts	811	701	1304	134	812	1169
			setupStore	19	9	45	7	23	36
			numNetworkReqs	104	67	282	54	97	271
	Webpack	Standard Home	uiStartup	825	711	1071	80	857	998
			load	639	565	844	69	651	823
			domContentLoaded	634	561	838	68	648	817
			domInteractive	26	15	100	21	22	89
			firstPaint	251	100	830	182	236	655
			backgroundConnect	9	6	29	4	10	18
			firstReactRender	28	20	98	9	32	38
			getState	28	13	58	11	37	48
			initialActions	1	0	4	1	1	1
			loadScripts	631	559	828	67	646	809
			setupStore	11	5	33	4	13	19
			numNetworkReqs	12	5	77	20	5	71
	Webpack	Power User Home	uiStartup	1710	1312	2519	294	1991	2259
			load	698	600	1248	115	708	1003
			domContentLoaded	688	593	1239	116	697	995
			domInteractive	39	18	193	38	33	149
			firstPaint	347	108	1247	267	625	950
			backgroundConnect	42	8	598	112	18	411
			firstReactRender	64	48	91	9	69	81
			getState	205	140	747	114	190	660
			initialActions	1	0	2	1	1	2
			loadScripts	685	591	1230	114	695	986
			setupStore	23	9	64	13	25	54
			numNetworkReqs	177	66	440	84	218	412
Firefox	Browserify	Standard Home	uiStartup	1326	1107	1842	160	1413	1651
			load	1095	958	1635	114	1150	1293
			domContentLoaded	1095	958	1635	114	1150	1293
			domInteractive	57	31	158	29	80	124
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	22	144	27	54	113
			firstReactRender	23	19	60	6	24	37
			getState	17	6	220	32	11	56
			initialActions	1	0	2	1	1	2
			loadScripts	1064	942	1529	98	1116	1274
			setupStore	11	5	50	7	10	27
			numNetworkReqs	12	5	66	17	6	63
	Browserify	Power User Home	uiStartup	2672	1903	5179	644	2828	4409
			load	1218	987	2732	351	1217	2542
			domContentLoaded	1217	987	2732	351	1217	2542
			domInteractive	110	34	471	96	102	387
			firstPaint	-	-	-	-	-	-
			backgroundConnect	130	34	1065	162	115	383
			firstReactRender	60	35	370	35	60	95
			getState	282	69	956	227	348	841
			initialActions	2	0	3	1	2	2
			loadScripts	1178	960	2578	321	1183	2168
			setupStore	184	6	813	221	166	703
			numNetworkReqs	101	62	247	58	87	241
	Webpack	Standard Home	uiStartup	1497	1272	2152	156	1582	1777
			load	1236	1091	1495	103	1292	1465
			domContentLoaded	1235	1091	1495	103	1292	1465
			domInteractive	55	27	167	32	82	118
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	20	203	34	45	127
			firstReactRender	26	20	39	4	27	35
			getState	15	6	166	23	12	23
			initialActions	1	0	3	1	2	2
			loadScripts	1211	1075	1444	96	1269	1411
			setupStore	13	6	73	12	11	44
			numNetworkReqs	12	5	71	16	7	62
	Webpack	Power User Home	uiStartup	2869	2087	4893	618	2914	4486
			load	1466	1173	2866	405	1493	2619
			domContentLoaded	1466	1172	2866	405	1493	2618
			domInteractive	119	28	1029	134	106	385
			firstPaint	-	-	-	-	-	-
			backgroundConnect	141	31	1268	174	148	318
			firstReactRender	63	41	190	18	65	95
			getState	284	67	950	208	400	777
			initialActions	2	1	31	3	2	3
			loadScripts	1403	1130	2555	328	1467	2448
			setupStore	145	6	702	183	133	598
			numNetworkReqs	103	61	250	61	82	244

📊 Page Load Benchmark Results

Current Commit: f468f23 | Date: 12/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 716ms (±37ms) 🟢 | historical mean value: 723ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	1.01s	1.32s	1.07s	1.32s
domContentLoaded	716ms	37ms	695ms	999ms	744ms	999ms
firstPaint	74ms	11ms	60ms	168ms	84ms	168ms
firstContentfulPaint	74ms	11ms	60ms	168ms	84ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 250 Bytes (0%)
common: 171 Bytes (0%)

ccharly

LGTM (not tested)

fix: when Network manager selection is Solana and a new popular netwo…

1ad6e12

…rk is added, the DeFi and NFTs tabs are missing

metamaskbot added the team-assets label Dec 1, 2025

github-actions bot added the size-M label Dec 1, 2025

salimtb changed the title ~~fix: when Network manager selection is Solana and a new popular netwo…~~ fix: when Network manager selection is Solana and a new popular network is added, the defi and NFTs tabs are missing Dec 1, 2025

fix: fix linter

5ae115c

salimtb marked this pull request as ready for review December 1, 2025 11:50

Merge branch 'main' into ASSETS-1573-bug-when-network-manager-selecti…

f468f23

…on-is-solana-and-a-new-popular-network-is-added-the-de-fi-and-nf-ts-tabs-are-missing

salimtb requested review from a team as code owners December 1, 2025 11:50

Prithpal-Sooriya approved these changes Dec 1, 2025

View reviewed changes

ccharly approved these changes Dec 1, 2025

View reviewed changes

salimtb added this pull request to the merge queue Dec 1, 2025

Merged via the queue into main with commit df8313f Dec 1, 2025
185 checks passed

salimtb deleted the ASSETS-1573-bug-when-network-manager-selection-is-solana-and-a-new-popular-network-is-added-the-de-fi-and-nf-ts-tabs-are-missing branch December 1, 2025 13:23

github-actions bot locked and limited conversation to collaborators Dec 1, 2025

metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Dec 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: when Network manager selection is Solana and a new popular network is added, the defi and NFTs tabs are missing #38419

fix: when Network manager selection is Solana and a new popular network is added, the defi and NFTs tabs are missing #38419

salimtb commented Dec 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

metamaskbot commented Dec 1, 2025

Uh oh!

metamaskbot commented Dec 1, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 1, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

ccharly left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: when Network manager selection is Solana and a new popular network is added, the defi and NFTs tabs are missing #38419

fix: when Network manager selection is Solana and a new popular network is added, the defi and NFTs tabs are missing #38419

Conversation

salimtb commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

metamaskbot commented Dec 1, 2025

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Dec 1, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Dec 1, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

salimtb commented Dec 1, 2025 •

edited

Loading