Skip to content

Conversation

@n3ps
Copy link
Contributor

@n3ps n3ps commented Dec 2, 2025

Description

Fix excess account list inline padding

Open in GitHub Codespaces

Changelog

CHANGELOG entry: chore: account list padding

Related issues

Fixes:

Manual testing steps

  1. Account details

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Cursor Bugbot is generating a summary for commit baf4907. Configure here.

@n3ps n3ps requested a review from a team as a code owner December 2, 2025 19:49
@n3ps n3ps added the team-core-extension-ux Core Extension UX team label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (1 files, +1 -1)
  • 📁 ui/
    • 📁 pages/
      • 📁 multichain-accounts/
        • 📁 account-list/
          • 📄 account-list.tsx +1 -1

@n3ps n3ps enabled auto-merge December 2, 2025 19:51
@metamaskbot
Copy link
Collaborator

Builds ready [baf4907]
UI Startup Metrics (1249 ± 114 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12491038163011413201457
load1045875142310410941251
domContentLoaded1039870141710210861246
domInteractive2515114192281
firstPaint51382144542110191244
backgroundConnect21619625412222246
firstReactRender31195683548
getState3616124164062
initialActions104112
loadScripts82966811971018831018
setupStore1264561323
numNetworkReqs1257720571
BrowserifyPower User HomeuiStartup19821640244016420732326
load994846143912510071294
domContentLoaded98183914061249881290
domInteractive3217113223199
firstPaint57210714493939521269
backgroundConnect248191648100223510
firstReactRender60401361863100
getState20315171076210258
initialActions1010112
loadScripts78165411911217891087
setupStore20958102142
numNetworkReqs936625227101151
WebpackStandard HomeuiStartup8426961122898631050
load64756591572657836
domContentLoaded64255990972651831
domInteractive2816121242399
firstPaint218108915141204602
backgroundConnect962941017
firstReactRender28215063337
getState281482123654
initialActions106112
loadScripts63955689870649821
setupStore1273451323
numNetworkReqs1257620571
WebpackPower User HomeuiStartup16361288243924817142128
load6875911178103694934
domContentLoaded6765861169103684925
domInteractive38171723635149
firstPaint297119882194315710
backgroundConnect80875717821587
firstReactRender6143102106682
getState19113491292190214
initialActions105113
loadScripts6735841158101681914
setupStore231058142653
numNetworkReqs1586639765220282
FirefoxBrowserifyStandard HomeuiStartup13201088187715013981622
load108894313739411581251
domContentLoaded108894313729411581251
domInteractive57312073380128
firstPaint------
backgroundConnect51221993562151
firstReactRender23185062438
getState146203241021
initialActions103122
loadScripts105792412878111211212
setupStore146184231133
numNetworkReqs1256917662
BrowserifyPower User HomeuiStartup27201959542567827324478
load1266942271239212812560
domContentLoaded1266942271139212812559
domInteractive1193450387127328
firstPaint------
backgroundConnect2042412102951441145
firstReactRender57361352058120
getState253611028212251801
initialActions208123
loadScripts1169924243422012451545
setupStore1728971218232637
numNetworkReqs915720734104166
WebpackStandard HomeuiStartup14991263211316316091817
load12381049147710613211453
domContentLoaded12381049147710613211453
domInteractive58271663280117
firstPaint------
backgroundConnect49203153655110
firstReactRender26188792739
getState167194281370
initialActions206134
loadScripts12111035144010212901406
setupStore14671111342
numNetworkReqs1256616761
WebpackPower User HomeuiStartup29932266573972129864729
load14991227296943114972845
domContentLoaded14991227296743114922845
domInteractive1153144387124329
firstPaint------
backgroundConnect1943113362771661056
firstReactRender65411482165118
getState304571068251478818
initialActions213123
loadScripts14021195264126414651760
setupStore1537684180178608
numNetworkReqs91622674194210
📊 Page Load Benchmark Results

Current Commit: baf4907 | Date: 12/2/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 728ms (±36ms) 🟢 | historical mean value: 722ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 39ms 1.02s 1.33s 1.07s 1.33s
domContentLoaded 728ms 36ms 705ms 994ms 749ms 994ms
firstPaint 77ms 10ms 60ms 168ms 84ms 168ms
firstContentfulPaint 77ms 10ms 60ms 168ms 84ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 16 Bytes (0%)
  • common: 20 Bytes (0%)

@n3ps n3ps requested a review from a team December 3, 2025 04:42
@n3ps n3ps added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit 638043d Dec 3, 2025
195 of 196 checks passed
@n3ps n3ps deleted the n3ps/fix-account-details-padding branch December 3, 2025 06:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
@metamaskbot metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.13.0 Issue or pull request that will be included in release 13.13.0 size-XS team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants