Out of order counter #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add binary compatible support for user defined transport nonces/counters.
This feature is required for transfers over UDP.
UDP has out-of-order messaging.
A new unit test
TestOutOfOrderis included.My CPU does not support Aes256Gcm and some vCPU's do not have Aes256Gcm enabled.
There is now an optional exclusion for Aes256GcmSupport in the NoiseTests.
One thing to mention is that only symmetric transports need to share the same counter,
but asymmetric transports should normally track two different counters for sending and receiving.