Add PacketLogger module #5989
Open
Add PacketLogger module #5989
+301
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The module works as intended, but there's alwasy room for improvement. |
src/main/java/meteordevelopment/meteorclient/systems/modules/misc/PacketLogger.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/systems/modules/misc/PacketLogger.java
Outdated
Show resolved
Hide resolved
- Use `Reference2IntOpenHashMap` for `packetCounts` - Add system to limit log file size and total size to avoid bloating the dir over extended usage - Add optional chat logging - Remove unnecessary info prints TODO: consider a writeLine helper for `fileWriter`
- early return `logPacket` if both outputs are off - `logSummary` prepares the lines in advance, prints later - centralized `writeLine` to handle IO ops Note: summary won't appear if both outputs are off, this makes sense since `packetCounts` would never be updated in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Add PacketLogger module.
Related issues
Closes #5686.
How Has This Been Tested?
Singleplayer testing.
Checklist: