-
Notifications
You must be signed in to change notification settings - Fork 424
Update deployment-local-identity-with-key-vault.md - updated instructions #3955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- consistency and better results using PowerShell instead of mix and match cmd. - updated description to PowerShell when wrong
|
@Karl-WE : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 4317425: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit bb09e06: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the DNS configuration instructions in the Azure Local deployment documentation to use PowerShell commands instead of CMD commands, improving consistency and modernizing the command-line examples.
- Replaced
nslookupCMD command with PowerShell'sResolve-DnsNamecmdlet - Updated code block language identifiers from
cmdtoPowershell
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Karl-WE
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted suggestions done by copilot
|
Learn Build status updates of commit 3910d0d: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 9290bd2: ✅ Validation status: passed
For more details, please refer to the build report. |

consistency and better results using PowerShell instead of mix and match cmd.
reasons: Resolve-DNSName results into more reliable and verbose output compared to nslookup. nslookup works on a different network stack compared to the PowerShell command.
updated description to PowerShell when wrong (line 93)