Skip to content

Conversation

@Karl-WE
Copy link
Contributor

@Karl-WE Karl-WE commented Oct 31, 2025

  • consistency and better results using PowerShell instead of mix and match cmd.
    reasons: Resolve-DNSName results into more reliable and verbose output compared to nslookup. nslookup works on a different network stack compared to the PowerShell command.

  • updated description to PowerShell when wrong (line 93)

- consistency and better results using PowerShell instead of mix and match cmd.

- updated description to PowerShell when wrong
@prmerger-automator
Copy link
Contributor

@Karl-WE : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@Karl-WE Karl-WE changed the title Update deployment-local-identity-with-key-vault.md Update deployment-local-identity-with-key-vault.md - updated instructions Oct 31, 2025
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 4317425:

✅ Validation status: passed

File Status Preview URL Details
azure-local/deploy/deployment-local-identity-with-key-vault.md ✅Succeeded

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit bb09e06:

✅ Validation status: passed

File Status Preview URL Details
azure-local/deploy/deployment-local-identity-with-key-vault.md ✅Succeeded

For more details, please refer to the build report.

@Karl-WE
Copy link
Contributor Author

Karl-WE commented Oct 31, 2025

example / output comparison
image

@ktoliver ktoliver requested a review from Copilot October 31, 2025 21:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the DNS configuration instructions in the Azure Local deployment documentation to use PowerShell commands instead of CMD commands, improving consistency and modernizing the command-line examples.

  • Replaced nslookup CMD command with PowerShell's Resolve-DnsName cmdlet
  • Updated code block language identifiers from cmd to Powershell

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ktoliver
Copy link
Contributor

@alkohli

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Oct 31, 2025
Copy link
Contributor Author

@Karl-WE Karl-WE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted suggestions done by copilot

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 3910d0d:

✅ Validation status: passed

File Status Preview URL Details
azure-local/deploy/deployment-local-identity-with-key-vault.md ✅Succeeded

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 9290bd2:

✅ Validation status: passed

File Status Preview URL Details
azure-local/deploy/deployment-local-identity-with-key-vault.md ✅Succeeded

For more details, please refer to the build report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants