Skip to content

Some nit improvements on libp2p #18100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: compatible
Choose a base branch
from
Open

Some nit improvements on libp2p #18100

wants to merge 2 commits into from
+23 −21

Conversation

@glyh
Copy link
Member

@glyh glyh commented Nov 12, 2025

This PR:

  • rename some variables in codanet.MakeHelper to enhance readability
  • ensure dir removal always happen after libp2p helper is closed, also ensure dir is removed when p2p helper creation is failed

@glyh glyh requested a review from a team as a code owner November 12, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glyh