[CI] Rename berkeley debian suffix to testnet-generic #18112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g up magic config to testnet-generic debian
Member
Author
|
!ci-nightly-me |
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-build-me |
dkijania
changed the title
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing testnet-generic docker/debian packages instead of berkeley.
Historically berkeley artifacts were used for long runing pre hf testnet for experimenting with berkeley prior to hardfork event. After that we were still using them as genesis config for berkeley (see for example discussion here: #17537 (comment)). The main reason to keep berkeley artifacts and still build them in CI, was not obvious. Since we didn't fork from berkeley , genesis config does not contain hard fork element, which is irreplaceable by chain of configs when running daemon, in contrary to devnet/mainnet. That would be fixed by full runtime config implementation, where we can replace every element of genesis config.
Till then, I'm proposing to replace berkeley with something more clear as per usage and rename it to testnet-generic. We need testnet prefix to suggest it is incompatible with mainnet and generic since it is not binded to any network. By default seed list is targeted to devnet but there is no genesis config loaded behind the scenes. Therefore such artifacts can interact in any testnet network.
Important things in this pr are: