-
Notifications
You must be signed in to change notification settings - Fork 168
fix(bugs): fix several bugs #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes several bugs related to program execution, configuration management, and output formatting. The changes ensure proper exit handling, improve output readability, and update configuration settings.
- Replace Fire-based CLI with direct argument parsing for better control
- Enable Hydra logging configuration and set proper output directory structure
- Add JSON indentation for better readability and improve file path handling
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/run-agent/main.py | Replaces Fire CLI with manual argument parsing and subprocess calls |
| apps/run-agent/common_benchmark.py | Adds signal handlers, switches to Hydra decorator, and fixes file path handling |
| libs/miroflow/src/miroflow/prebuilt/config/config.yaml | Enables Hydra logging and configures output directory |
| libs/miroflow/src/miroflow/logging/task_tracer.py | Adds JSON indentation for better output formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
shiqian-su
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use !data/README.md in .gitignore to keep README file.
Describe this PR
Checklist for PR
Must Do
feat(agent): add pdf tool via mcp,perf: make llm client asyncandfix(utils): load custom config via importlibetc. CI jobcheck-pr-titleenforces Angular commit message format to PR title.make precommitlocally. CI joblintenforce ruff default format/lint rules on all new codes.make pytest. Check test summary (located atreport.html) and coverage report (located athtmlcov/index.html) on new codes.Nice To Have
/testsforfeatandtestPR./docsfordocsandciPR.