Skip to content

Conversation

@ntudy
Copy link
Contributor

@ntudy ntudy commented Aug 19, 2025

Describe this PR

  1. make sure program exit properly
  2. update gitignore
  3. disable fire and save hydra config
  4. save result file as json with indent
  5. make sure file_path is complete

Checklist for PR

Must Do

  • Write a good PR title and description, i.e. feat(agent): add pdf tool via mcp, perf: make llm client async and fix(utils): load custom config via importlib etc. CI job check-pr-title enforces Angular commit message format to PR title.
  • Run make precommit locally. CI job lint enforce ruff default format/lint rules on all new codes.
  • Run make pytest. Check test summary (located at report.html) and coverage report (located at htmlcov/index.html) on new codes.

Nice To Have

  • (Optional) Write/update tests under /tests for feat and test PR.
  • (Optional) Write/update docs under /docs for docs and ci PR.

@ntudy ntudy requested review from Copilot and shiqian-su August 19, 2025 10:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several bugs related to program execution, configuration management, and output formatting. The changes ensure proper exit handling, improve output readability, and update configuration settings.

  • Replace Fire-based CLI with direct argument parsing for better control
  • Enable Hydra logging configuration and set proper output directory structure
  • Add JSON indentation for better readability and improve file path handling

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
apps/run-agent/main.py Replaces Fire CLI with manual argument parsing and subprocess calls
apps/run-agent/common_benchmark.py Adds signal handlers, switches to Hydra decorator, and fixes file path handling
libs/miroflow/src/miroflow/prebuilt/config/config.yaml Enables Hydra logging and configures output directory
libs/miroflow/src/miroflow/logging/task_tracer.py Adds JSON indentation for better output formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ntudy ntudy requested a review from gali-leilei August 19, 2025 10:05
Copy link
Contributor

@shiqian-su shiqian-su left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use !data/README.md in .gitignore to keep README file.

@shiqian-su shiqian-su merged commit 1281e35 into main Aug 20, 2025
8 checks passed
@shiqian-su shiqian-su deleted the dev-fix-bug branch August 20, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants