Skip to content

Conversation

@gali-leilei
Copy link
Contributor

@gali-leilei gali-leilei commented Aug 8, 2025

Describe this PR

  • fix missing instruction, environmental_variable and typo when onboarding new user with readme.md.

Checklist for PR

Must Do

  • Write a good PR title and description, i.e. feat(agent): add pdf tool via mcp, perf: make llm client async and fix(utils): load custom config via importlib etc. CI job check-pr-title enforces Angular commit message format to PR title.
  • Run make precommit locally. CI job lint enforce ruff default format/lint rules on all new codes.
  • Run make pytest. Check test summary (located at report.html) and coverage report (located at htmlcov/index.html) on new codes.

Nice To Have

  • (Optional) Write/update tests under /tests for feat and test PR.
  • (Optional) Write/update docs under /docs for docs and ci PR.

@gali-leilei gali-leilei requested a review from RogerChern August 8, 2025 10:32
Copy link
Member

@RogerChern RogerChern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gali-leilei gali-leilei merged commit ce95922 into main Aug 8, 2025
7 of 8 checks passed
@gali-leilei gali-leilei deleted the dev-make-readme-reproducible branch August 8, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants