Skip to content

Conversation

@miyoungc
Copy link
Collaborator

Description

Edits #1483

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@miyoungc miyoungc requested a review from Pouyanpi October 31, 2025 22:53
@miyoungc miyoungc self-assigned this Oct 31, 2025
@miyoungc miyoungc added the documentation Improvements or additions to documentation label Oct 31, 2025
@miyoungc miyoungc added this to the v0.18.0 milestone Oct 31, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Refines the LLM reasoning traces documentation with improved structure and clarity. Key changes include converting the warning directive to a deprecated directive for better semantic accuracy, restructuring the "Accessing Reasoning Traces" section with clearer decision guidance upfront, adding descriptive subheadings throughout, improving bullet point formatting with periods for consistency, and enhancing code example explanations with more detailed context and expected outputs.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - documentation-only changes improve clarity without affecting code behavior
  • This PR contains only documentation improvements with no code changes. The edits enhance readability, use appropriate directive syntax (deprecated instead of warning), add helpful structure with better headings and formatting, and provide clearer guidance for users choosing between API patterns
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
docs/user-guides/configuration-guide/llm-configuration.md 5/5 Documentation improvements: better structure, clearer examples, improved readability with consistent formatting and organization

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Doc as Documentation
    participant User as End User
    
    Dev->>Doc: Edit PR #1483 content
    Note over Doc: Change warning to deprecated
    Note over Doc: Restructure examples
    Note over Doc: Add clearer headings
    Note over Doc: Improve bullet formatting
    Doc->>User: Present improved docs
    Note over User: Better understanding of:<br/>- GenerationOptions usage<br/>- Reasoning traces setup<br/>- Configuration patterns
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR improves the LLM configuration documentation by enhancing clarity, organization, and readability. Key changes include:

  • Changed the breaking change warning to a proper deprecated directive for the reasoning_config field
  • Reorganized the "Guardrailing Reasoning Traces" section with a new "Prepare Configuration Files" subsection using numbered steps
  • Improved explanation of when the NeMo Guardrails toolkit extracts reasoning traces and how to access them via $bot_thinking and bot_thinking variables
  • Moved the "which pattern to use" guidance earlier in the "Accessing Reasoning Traces in API Responses" section for better flow
  • Enhanced Python code examples with detailed inline comments explaining each step
  • Added example outputs to demonstrate the expected results
  • Improved consistency in formatting with proper punctuation and clearer language throughout

All changes are editorial improvements that make the documentation more accessible and easier to follow without altering any technical content or functionality.

Confidence Score: 5/5

  • This PR is safe to merge with no risk - it contains only documentation improvements
  • The PR only modifies documentation with editorial improvements for clarity and readability. No code changes, no functionality changes, and no technical accuracy issues were found. The changes properly use the deprecated directive, improve section organization, and enhance code examples with helpful comments.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
docs/user-guides/configuration-guide/llm-configuration.md 5/5 Documentation improvements for clarity, structure, and readability; changed warning to deprecated directive; enhanced section organization

Sequence Diagram

sequenceDiagram
    participant User as Documentation Reader
    participant Doc as llm-configuration.md
    participant Config as config.yml
    participant Prompts as prompts.yml
    participant API as NeMo Guardrails API
    
    User->>Doc: Read documentation changes
    Note over Doc: Changed warning to deprecated directive<br/>Improved structure and clarity
    
    Doc->>User: Learn about reasoning traces setup
    Note over Doc: Added subsection "Prepare Configuration Files"<br/>Reorganized content with numbered steps
    
    User->>Config: Configure output rails
    Note over Config: Set up main model and self_check_output
    
    User->>Prompts: Configure prompts for reasoning access
    Note over Prompts: Use bot_thinking variable
    
    User->>Doc: Learn API response patterns
    Note over Doc: Clarified when to use each pattern<br/>Moved guidance earlier in section
    
    User->>API: Call with GenerationOptions
    API-->>User: Return structured GenerationResponse
    Note over API: reasoning_content + response fields
    
    User->>API: Call without GenerationOptions
    API-->>User: Return string with <think> tags
    Note over API: Inline reasoning in response
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@Pouyanpi Pouyanpi merged commit 11010d0 into NVIDIA-NeMo:docs/llm-configuration-update Nov 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants