Skip to content

Conversation

@tdene
Copy link
Contributor

@tdene tdene commented Nov 17, 2025

What does this PR do ?

REVIEWERS PLEASE NOTE:
This is a stacked PR. The diff here is misleading. The true diff can be found at #11.

The current synchronous ZMQ communication does not allow for other tasks to run in parallel to the engine. This is a blocker that prevents RL.

Furthermore, there are various complications and race conditions that are eliminated when switching to an asynchronous system.

BENCHMARK INFO:
The "golden" benchmark after this PR returns an average value of XXX, with expected noise of +/- 2%.
The "golden" benchmark prior to this PR returns an average value of XXX, with expected noise of +/- 2%.
This shows no degradation.

The "unit-test" benchmark after this PR returns average values as seen below, with expected noise of +/- 5%.

Initialization time: X ms
Run time: X ms
Stop time: X ms
ZMQ throughput is approximately X requests/ms

The "unit-test" benchmark prior to this PR returns average values as seen below, with expected noise of +/- 5%.

Initialization time: X ms
Run time: X ms
Stop time: X ms
ZMQ throughput is approximately X requests/ms

This shows no degradation.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 17, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@tdene tdene force-pushed the tde/zmq_async branch 3 times, most recently from 96030c9 to c840afb Compare November 19, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant