Optimize calibrate_draft_vocab to read only required lines when calib… #618
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rate_size is set Signed-off-by: Ofir Ben Shoham <[email protected]>
Ofir408
force-pushed
the
feature/optimize-calibrate-vocab-reading
branch
from
a271623 to
a3bc080
Compare
yeyu-nvidia
approved these changes
Dec 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
=======================================
Coverage 74.64% 74.64%
=======================================
Files 183 183
Lines 18542 18542
=======================================
Hits 13840 13840
Misses 4702 4702 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize calibrate_draft_vocab to read only required lines when calibrate_size is set
What does this PR do?
Type of change: Performance improvement
Overview:
This PR optimizes the calibrate_draft_vocab.py script to improve memory efficiency and I/O performance when using the
--calibrate_sizeparameter. Previously, the script would read all lines from the data file into memory before slicing to the specifiedcalibrate_size, causing unnecessary resource usage for large datasets. The optimization usesitertools.isliceto read only the required number of lines whencalibrate_sizeis specified.Usage
The script usage remains unchanged. When using
--calibrate_size, the script now only reads the specified number of lines instead of loading the entire dataset:# Only reads first 1000 lines from the dataset (optimized) python scripts/calibrate_draft_vocab.py \ --model meta-llama/Llama-3.2-1B-Instruct \ --data input_conversations/daring-anteater.jsonl \ --draft_vocab_size 32000 \ --calibrate_size 1000 \ --save_dir draft_vocab_cache