Fix: Remove redundant parameters of update function in device GemmUniversal #2777
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
udpatefunction of device GemmUniversal's column-major specialization has aworkspaceparameter, and it's passed tounderlying_operator_:cutlass/include/cutlass/gemm/device/gemm_universal.h
Lines 404 to 407 in a243955
But the
updatefunction of theunderlying_operator_, that is,GemmUniversalBase, don't have this paramerter:cutlass/include/cutlass/gemm/device/gemm_universal_base.h
Lines 423 to 428 in a243955
This leads to compile error when using the column-major specialization, so I removed it.