fix missing header on examples #1854
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profiler headers reference ncclResult_t which is declared in err.h
Errors building CoMMA example:
Unable to generate bindings for third_party/nccl/ext-profiler/example/nccl/profiler.h: clang diagnosed error: third_party/nccl/ext-profiler/example/nccl/profiler_v5.h:124:3: error: type name requires a specifier or qualifier
third_party/nccl/ext-profiler/example/nccl/profiler_v5.h:132:3: error: type name requires a specifier or qualifier
third_party/nccl/ext-profiler/example/nccl/profiler_v5.h:132:18: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
third_party/nccl/ext-profiler/example/nccl/profiler_v5.h:132:3: error: duplicate member 'ncclResult_t'
All 3 examples build and run fine with this tiny change.
Also use release version of CoMMA following its intructions https://cloud.google.com/ai-hypercomputer/docs/nccl/configure-comma#build-from-source
Thank you!