Skip to content

Conversation

@henrique
Copy link

The profiler headers reference ncclResult_t which is declared in err.h

Errors building CoMMA example:
Unable to generate bindings for third_party/nccl/ext-profiler/example/nccl/profiler.h: clang diagnosed error: third_party/nccl/ext-profiler/example/nccl/profiler_v5.h:124:3: error: type name requires a specifier or qualifier
third_party/nccl/ext-profiler/example/nccl/profiler_v5.h:132:3: error: type name requires a specifier or qualifier
third_party/nccl/ext-profiler/example/nccl/profiler_v5.h:132:18: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
third_party/nccl/ext-profiler/example/nccl/profiler_v5.h:132:3: error: duplicate member 'ncclResult_t'

All 3 examples build and run fine with this tiny change.

Also use release version of CoMMA following its intructions https://cloud.google.com/ai-hypercomputer/docs/nccl/configure-comma#build-from-source

Thank you!

@Kaiyuan-Zhang
Copy link

FYI, #1848 is trying to fix the same missing header issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants