Skip to content

Drain error code when kernel is not found #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Drain error code when kernel is not found #1864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4360748
Drain error code when kernel is not found
malfet Oct 1, 2025
01e6dd9
Update src/enqueue.cc
malfet Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/enqueue.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ ncclResult_t ncclInitKernelsForDevice(int cudaArch, int maxSharedMem, size_t* ma
if (fn == nullptr) continue;

cudaError_t errcode = cudaFuncGetAttributes(&attr, fn);
if (errcode != cudaSuccess) continue; // Silently ignore failures
if (errcode != cudaSuccess) {
cudaGetLastError(); // Drain error code
continue; // Silently ignore failures
}
if (maxStackSize) {
if (attr.localSizeBytes > *maxStackSize) *maxStackSize = attr.localSizeBytes;
}
Expand Down