Skip to content

Disregard task killed, use toErrorString for diagnostics #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Disregard task killed, use toErrorString for diagnostics #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca36ac3
Disregard task killed, use toErrorStting for diagnostics
gerashegalov Jan 22, 2024
298f748
Merge remote-tracking branch 'origin/dev' into disregardKilledTasks
gerashegalov Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions nds/jvm_listener/src/main/scala/com/nvidia/spark/rapids/listener/TaskFailureListener.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

package com.nvidia.spark.rapids.listener

import org.apache.spark.{Success, TaskEndReason}
import org.apache.spark.{Success, TaskEndReason, TaskFailedReason, TaskKilled}
import org.apache.spark.scheduler.{SparkListener, SparkListenerTaskEnd}
import scala.collection.mutable.ListBuffer

Expand All @@ -29,8 +29,9 @@ import scala.collection.mutable.ListBuffer
class TaskFailureListener extends SparkListener {
override def onTaskEnd(taskEnd: SparkListenerTaskEnd) {
taskEnd.reason match {
case Success =>
case reason => Manager.notifyAll(reason.toString)
case Success => ()
case _: TaskKilled => ()
case failedReason: TaskFailedReason => Manager.notifyAll(failedReason.toErrorString)
}
super.onTaskEnd(taskEnd)
}
Expand Down