Add warmup_iterations and iterations back #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jihoon Son <[email protected]>
jihoonson
force-pushed
the
re-add-iterations
branch
from
7ef00fd to
5054d4a
Compare
Collaborator
Author
|
I have tested this change against the CI job that my previous PR (#202) broke. |
abellina
approved these changes
Mar 20, 2025
Collaborator
abellina
left a comment
abellina
left a comment
There was a problem hiding this comment.
looks good, thanks @jihoonson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new options were added in #202, but that PR had to be reverted in #207 as it caused a couple of issues in #204. This PR adds the reverted change back only for NDS after the issues in #204 have been fixed. To support new options for NDS-H, we should resolve #206.
I wonder though what is the best way to test my change, so that I won't break things again. Appreciate any suggestion for testing.