Skip to content

Add support for saving query plans #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2025
Merged

Add support for saving query plans #212

merged 4 commits into from
Apr 30, 2025

Conversation

@jihoonson
Copy link
Collaborator

@jihoonson jihoonson commented Apr 18, 2025 •
edited
Loading

This PR introduces three new configs to save query plans using the benchmark script.

  --save_plan_path SAVE_PLAN_PATH
                        Save the execution plan of each query to the specified file. If --skip_execution is specified, the execution plan will be saved without executing the
                        query.
  --plan_types PLAN_TYPES
                        Comma separated list of plan types to save. e.g. "physical, logical". Default is "logical".
  --skip_execution      Skip the execution of the queries. This can be used in conjunction with --save_plan_path to only save the execution plans without running the queries.

@jihoonson
support nds-h
7b5953f 
Signed-off-by: Jihoon Son <[email protected]>
@jihoonson jihoonson marked this pull request as ready for review April 24, 2025 20:49
zpuller
zpuller approved these changes Apr 28, 2025
View reviewed changes
Copy link

@zpuller zpuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one question about duplicate code (maybe we could address it in a separate PR if we want)

gerashegalov
gerashegalov reviewed Apr 28, 2025
View reviewed changes
gerashegalov
gerashegalov reviewed Apr 28, 2025
View reviewed changes
gerashegalov
gerashegalov previously approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nds/nds_power.py Outdated
ensure_valid_column_names(df).write.format(output_format).mode('overwrite').save(
output_path + '/' + query_name)
if save_plan_path:
subprocess.run(f"mkdir -p {save_plan_path}", shell=True)
Copy link
Collaborator

@gerashegalov gerashegalov Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider https://docs.python.org/3.12/library/os.html#os.makedirs instead of forking shell commands

@jihoonson
Copy link
Collaborator Author

jihoonson commented Apr 30, 2025

@gerashegalov @zpuller thanks for the review

@jihoonson jihoonson merged commit a786d21 into NVIDIA:dev Apr 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gerashegalov gerashegalov gerashegalov approved these changes

+1 more reviewer

@zpuller zpuller zpuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jihoonson @gerashegalov @zpuller