Skip to content

Conversation

@jihoonson
Copy link
Collaborator

-- Template file: 15

create temp view revenue1 (supplier_no, total_revenue) as ...;

select ...;

drop view revenue1;

The query parsing for NDS-H can support a test that runs multiple queries in it like the query 15 as seen above. The parsing currently has the query number 15 hard-coded in it for multi-query support. It skips the parsing otherwise. This hard-coded query number is unnecessary. The parsing also currently assumes that there are always 3 queries after parsing, which can be false. This PR generalizes the parsing logic to fix these problems.

Copy link
Collaborator

@sayedbilalbari sayedbilalbari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jihoonson for the improvement. LGTM

@jihoonson
Copy link
Collaborator Author

@sayedbilalbari thanks for the review!

@jihoonson jihoonson merged commit 7447499 into NVIDIA:dev Sep 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants