Fix: JobSet with @retry(times=0) validation error #2672
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using @Retry(times=0) with JobSet through Argo Workflows, the workflow fails because {{retries}} is added to the jobset-name even though retryStrategy is not specified in the template. The issue was that the code checked for the presence of the @Retry decorator instead of checking if retries are actually enabled (total_retries > 0). When total_retries = 0, retry_strategy() doesn't add retryStrategy, so {{retries}} is not available in Argo Workflows. Fix by computing total_retries and only adding retry-related parameters (including {{retries}} in the jobset-name) when total_retries > 0. Fixes Netflix#2632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using @Retry(times=0) with JobSet through Argo Workflows, the workflow fails because {{retries}} is added to the jobset-name even though retryStrategy is not specified in the template.
The issue was that the code checked for the presence of the @Retry decorator instead of checking if retries are actually enabled (total_retries > 0). When total_retries = 0, retry_strategy() doesn't add retryStrategy, so {{retries}} is not available in Argo Workflows.
Fix by computing total_retries and only adding retry-related parameters (including {{retries}} in the jobset-name) when total_retries > 0.
Fixes #2632