Merge pull request #4006 from Nexus-Mods/remove-dispose-debugassert

Al12rs · web-flow · commit b2327d50e383 · 2025-10-21T14:46:04.000+02:00
Remove incorrect !isDisposed debug assert from TreeDataGrid selection observable
diff --git a/src/NexusMods.App.UI/Controls/TreeDataGrid/TreeDataGridAdapter.cs b/src/NexusMods.App.UI/Controls/TreeDataGrid/TreeDataGridAdapter.cs
@@ -101,7 +101,6 @@ protected TreeDataGridAdapter()
                     {
                         foreach (var item in self.SelectedModels)
                         {
-                            Debug.Assert(!item.IsDisposed);
                             if (item.IsDisposed) continue;
                             item.IsSelected.Value = false;
                         }
@@ -115,7 +114,6 @@ protected TreeDataGridAdapter()
                         foreach (var item in eventArgs.DeselectedItems)
                         {
                             if (item is null) continue;
-                            Debug.Assert(!item.IsDisposed);
                             if (item.IsDisposed) continue;
                             
                             item.IsSelected.Value = false;

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,6 @@ protected TreeDataGridAdapter()`
`101`	`101`	`{`
`102`	`102`	`foreach (var item in self.SelectedModels)`
`103`	`103`	`{`
`104`		`- Debug.Assert(!item.IsDisposed);`
`105`	`104`	`if (item.IsDisposed) continue;`
`106`	`105`	`item.IsSelected.Value = false;`
`107`	`106`	`}`
`@@ -115,7 +114,6 @@ protected TreeDataGridAdapter()`
`115`	`114`	`foreach (var item in eventArgs.DeselectedItems)`
`116`	`115`	`{`
`117`	`116`	`if (item is null) continue;`
`118`		`- Debug.Assert(!item.IsDisposed);`
`119`	`117`	`if (item.IsDisposed) continue;`
`120`	`118`
`121`	`119`	`item.IsSelected.Value = false;`