feat: (un)subscribe button #527
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The simple stupid way to do separate the code path for pure-HTML is to have a regular POST response for the full page reload, and let the htmx annotation on the button call a different endpoint that serves just that purpose. It's slightly noisy because you'd need to add an extra URL and view, and eventually we'd better build an abstraction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #173. Depends on #526. Adds a (un)subscribe button on the issue detail view to subscribe or unsubscribe to a specific issue. The front-end part is currently really basic, let's use this PR as a basis for discussion.
TODO/To discuss