Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
from django.db import migrations, models, transaction
import django.db.models.deletion

def populate_package_field(apps, schema_editor):
NixPackage = apps.get_model('shared', 'NixPackage')
NixDerivation = apps.get_model('shared', 'NixDerivation')

with transaction.atomic():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably stop the world for a long time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did take something like 5 min. Do you know how it could be optimized?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally something like here: https://github.com/Nix-Security-WG/nix-security-tracker/pull/538/files

But see my top level comment for why we may not need that anyway

for derivation in NixDerivation.objects.all():
package, _ = NixPackage.objects.get_or_create(name=derivation.attribute)
derivation.package = package
derivation.save()

def reverse_populate_package_field(apps, schema_editor):
NixDerivation = apps.get_model('shared', 'NixDerivation')
NixDerivation.objects.update(package=None)


class Migration(migrations.Migration):

dependencies = [
('shared', '0048_remove_attribute_suffix'),
]

operations = [
migrations.CreateModel(
name='NixPackage',
fields=[
('id', models.BigAutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=255, unique=True)),
],
),
migrations.AddField(
model_name='nixderivation',
name='package',
field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.CASCADE, to='shared.nixpackage'),
),
migrations.RunPython(populate_package_field, reverse_populate_package_field),
migrations.AlterField(
model_name='nixderivation',
name='package',
field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='shared.nixpackage'),
),
]
8 changes: 8 additions & 0 deletions src/website/shared/models/nix_evaluation.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,13 @@ class Meta: # type: ignore[override]
unique_together = ("channel", "commit_sha1")


class NixPackage(models.Model):
name = models.CharField(max_length=255, unique=True)

def __str__(self) -> str:
return self.name


class NixDerivation(models.Model):
"""
This represents a Nix derivation "evaluated",
Expand All @@ -279,6 +286,7 @@ class NixDerivation(models.Model):
- parsing the .drv
"""

package = models.ForeignKey(NixPackage, on_delete=models.CASCADE, null=True)
attribute = models.CharField(max_length=255)
derivation_path = models.CharField(max_length=255)
dependencies = models.ManyToManyField(NixDerivationOutput)
Expand Down