Build abstraction for computing saturation vapor pressure over mixed phase surfaces #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
glwagner
added
the
thermodynamics 🔥
kaiyuan-cheng
approved these changes
Nov 11, 2025
giordano
reviewed
Nov 11, 2025
Co-authored-by: Mosè Giordano <[email protected]>
glwagner
commented
Nov 11, 2025
Member
Author
|
better tests in a future PR |
giordano
reviewed
Nov 11, 2025
| Δcˡ = cᵖᵛ - cˡ | ||
| ``` | ||
|
|
||
| This difference ``\Delta c^l ≈`` $(round(1885 - 4181, digits=1)) J/(kg⋅K) is negative because |
Collaborator
There was a problem hiding this comment.
I don't think you can do that in markdown
Suggested change
| This difference ``\Delta c^l ≈`` $(round(1885 - 4181, digits=1)) J/(kg⋅K) is negative because | |
| This difference ``\Delta c^l ≈`` -2296.0 J/(kg⋅K) is negative because |
?
Collaborator
There was a problem hiding this comment.
Yeah, this is not doing what you wanted: https://numericalearth.github.io/BreezeDocumentation/previews/PR142/thermodynamics/#Example:-liquid-water-and-ice-parameters. Edit: done in #143 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fleshes out our abstractions for computing the saturation vapor pressure. It adds the concept of a "surface" over which the saturation vapor pressure is to be computed, and builds support for
PlanarLiquidSurfacePlanarIceSurfacePlanarMixedPhaseSurfacewithPlanarMixedPhaseSurface.liquid_fractionThis encodes an expectation that we may also want to compute saturation vapor pressure over curved surfaces in the future.
Once we add docs and test for this, we can then start work on mixed phase saturation adjustment, which will use this new feature to compute the saturation specific humidity in a mixed phase situation.