Skip to content

Better assignment of main category #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 8.0
Choose a base branch
from
Open

Better assignment of main category #237

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6cf79f
removing random overwrite (choosing just last category as main) if the
gfcapalbo Sep 29, 2016
fc61180
actually accessing openerp data from the backend
gfcapalbo Sep 29, 2016
8dfe9f1
fix
gfcapalbo Sep 29, 2016
37f08e4
final fix for junglegym
gfcapalbo Sep 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions magentoerpconnect/product.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ def product_type_get(self):
('simple', 'Simple Product'),
('configurable', 'Configurable Product'),
('virtual', 'Virtual Product'),
('downloadable', 'Downloadable Product'),
# XXX activate when supported
('downloadable', 'Downloadable Product'),# XXX activate when supported
# ('grouped', 'Grouped Product'),
# ('bundle', 'Bundle Product'),
]
Expand Down Expand Up @@ -469,10 +468,10 @@ def website_ids(self, record):
def categories(self, record):
mag_categories = record['categories']
binder = self.binder_for('magento.product.category')

category_ids = []
product_id=[]
curr_product = self.binder_for('magento.product.product').to_openerp(record['product_id'], browse=True)
category_ids = []
main_categ_id = None

for mag_category_id in mag_categories:
cat_id = binder.to_openerp(mag_category_id, unwrap=True)
if cat_id is None:
Expand All @@ -482,16 +481,21 @@ def categories(self, record):

category_ids.append(cat_id)

#do not pop from extra categories
if category_ids:
main_categ_id = category_ids.pop(0)
main_categ_id = category_ids[0]

if main_categ_id is None:
default_categ = self.backend_record.default_category_id
if default_categ:
main_categ_id = default_categ.id

result = {'categ_ids': [(6, 0, category_ids)]}
if main_categ_id: # OpenERP assign 'All Products' if not specified
# OpenERP assign 'All Products' if not specified
# skip main cat assignment if the current main category is already in
# categ_ids
if ((main_categ_id and not curr_product) or
(main_categ_id and curr_product.categ_id not in category_ids)):
result['categ_id'] = main_categ_id
return result

Expand Down