[19.0][MIG] purchase_order_supplier_return: Migration to 19.0 #2883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (1 of 1 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_supplier_return Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_supplier_return/it/
Currently translated at 100.0% (1 of 1 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_supplier_return Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_supplier_return/fr/
Currently translated at 100.0% (1 of 1 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_supplier_return Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_supplier_return/hr/
sergioM-S73
force-pushed
the
19.0-mig-purchase_order_supplier_return
branch
from
7062a47 to
54bb6c9
Compare
sergioM-S73
force-pushed
the
19.0-mig-purchase_order_supplier_return
branch
from
54bb6c9 to
705096c
Compare
Contributor
|
@sergioM-S73 I made the functional review and this module in a odoo 19.0 is useless. Odo base made this functionality without this module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating this module to v19, I ran into a test failure. The root cause is a core change in Odoo 19: the to_refund field on stock.move now defaults to True.
odoo/odoo@98fbff3
This caused the test to fail on the positive-quantity PO line, as it expected the value to be False.
My first thought was to adapt the module's logic to do the inverse (setting to_refund = False on standard receipts), however, I believe this is incorrect.
This situation led me to question the module's necessity.
#2116
To verify, I ran tests on Runboat instances for versions 16, 17, 18, and 19. In all cases, when validating a return picking generated from a purchase order with a negative quantity line, the received quantity is correctly updated
Therefore, I conclude that this module is redundant