Skip to content

Conversation

@sergiocorato
Copy link

@sergiocorato sergiocorato commented Apr 11, 2025

The name of the downloaded file is always in the user language.

With this PR the name is translatable on the object.lang field [to be added to the object used to create the report].

@sergiocorato sergiocorato force-pushed the 14.0-IMP-report_xlsx-translate-filename branch from 6276196 to 482f0be Compare April 11, 2025 14:11
@sergiocorato
Copy link
Author

@ivs-cetmix
Copy link
Member

@sergiocorato thank you for your contribution! Could you please rebase your PR add the test coverage if codevov tests are still not ok?

@rvalyi rvalyi changed the title [IMP] translate filename xlsx [14.0][IMP] translate filename xlsx Jul 11, 2025
@sergiocorato sergiocorato force-pushed the 14.0-IMP-report_xlsx-translate-filename branch from 482f0be to d89eef9 Compare July 11, 2025 20:46
@sergiocorato
Copy link
Author

sergiocorato commented Jul 13, 2025

@sergiocorato thank you for your contribution! Could you please rebase your PR add the test coverage if codevov tests are still not ok?

Done, probably they will be green only adding some tests.

Thank you @ivs-cetmix !

@ivs-cetmix
Copy link
Member

@sergiocorato looks better, however you should try to improve the test coverage as well. Check the codedove/patch test results for details.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants