-
-
Notifications
You must be signed in to change notification settings - Fork 855
[18.0][MIG] report_footer_html: Migration to 18.0 #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
44fdd5a to
0212d99
Compare
chienandalu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment (other than that seems ok)
d709819 to
3ed16dc
Compare
3ed16dc to
648c322
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and the work on this module @u0f . I’ve run an initial round of functional tests in Odoo to validate the behaviour, and most scenarios are working as expected. I’ve found one issue related to image rendering in the HTML footer that might require your review.
Below is the summary of the tests performed:
Test 1: Basic HTML in quotation footer – OK
Test 2: Complex HTML (text + link + simulated logo) in Standard layout – No OK (the link is not clickable and the logo is not displayed)
Test 3: Coexistence with native footer in Striped/Wave layouts – OK
Test 4: Report without Extra Footer content – OK
Test 5: Bottom margin adjustment in Paper Format – OK
Test 6: Footer rendering in qweb-html preview – OK
Test 7: Different HTML footers per report type – OK
Test 8: Footer with image in Extra Footer – Not OK (the image is not rendered in PDF)
Could you please take a look at this case?
Thank you @u0f
648c322 to
8391f66
Compare
|
Thanks for your review, @fcvalgar. I’ve been testing adding images to the Extra Footer and didn’t run into any issues — the image is correctly rendered in every Document Layout.
Regarding the links issue, I’ve been looking into it. This is not actually a bug but an Odoo limitation. In the footer, you can’t add hyperlinked text through the editor, but you can paste link as plain test and it will work.
|
fcvalgar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@u0f Thank you for the detailed explanation. The type of image I was using was not correct.
LGTM
|
This PR has the |
1 similar comment
|
This PR has the |


MIgration to 18:
https://www.loom.com/share/7b1a82749aff4adc8c4776c67992f6e0
MT-12187 @moduon @Shide