Skip to content

Conversation

@u0f
Copy link

@u0f u0f commented Nov 12, 2025

MIgration to 18:

  • Support new Odoo native documents layout
  • Update translations
  • Update README

https://www.loom.com/share/7b1a82749aff4adc8c4776c67992f6e0

MT-12187 @moduon @Shide

@u0f u0f force-pushed the 18.0-mig-report_footer_html branch from 44fdd5a to 0212d99 Compare November 12, 2025 08:34
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment (other than that seems ok)

@u0f u0f force-pushed the 18.0-mig-report_footer_html branch 2 times, most recently from d709819 to 3ed16dc Compare November 12, 2025 14:12
@u0f u0f changed the title [MIG] report_footer_html: Migration to 18.0 [18.0][MIG] report_footer_html: Migration to 18.0 Nov 17, 2025
@u0f u0f changed the title [18.0][MIG] report_footer_html: Migration to 18.0 [18.0][MIG] report_footer_html Nov 17, 2025
@u0f u0f changed the title [18.0][MIG] report_footer_html [18.0][MIG] report_footer_html: Migration to 18.0 Nov 17, 2025
@u0f u0f force-pushed the 18.0-mig-report_footer_html branch from 3ed16dc to 648c322 Compare November 17, 2025 11:10
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and the work on this module @u0f . I’ve run an initial round of functional tests in Odoo to validate the behaviour, and most scenarios are working as expected. I’ve found one issue related to image rendering in the HTML footer that might require your review.

Below is the summary of the tests performed:

Test 1: Basic HTML in quotation footer – OK
Test 2: Complex HTML (text + link + simulated logo) in Standard layout – No OK (the link is not clickable and the logo is not displayed)

image

Test 3: Coexistence with native footer in Striped/Wave layouts – OK
Test 4: Report without Extra Footer content – OK
Test 5: Bottom margin adjustment in Paper Format – OK
Test 6: Footer rendering in qweb-html preview – OK
Test 7: Different HTML footers per report type – OK
Test 8: Footer with image in Extra Footer – Not OK (the image is not rendered in PDF)

image image

Could you please take a look at this case?

Thank you @u0f

@u0f u0f force-pushed the 18.0-mig-report_footer_html branch from 648c322 to 8391f66 Compare November 20, 2025 14:11
@u0f
Copy link
Author

u0f commented Nov 20, 2025

Thanks for your review, @fcvalgar.

I’ve been testing adding images to the Extra Footer and didn’t run into any issues — the image is correctly rendered in every Document Layout.

Tested on RunBoat

Regarding the links issue, I’ve been looking into it. This is not actually a bug but an Odoo limitation. In the footer, you can’t add hyperlinked text through the editor, but you can paste link as plain test and it will work.
I’ve added this information to the ROADMAP.md`.

image

Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@u0f Thank you for the detailed explanation. The type of image I was using was not correct.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants